[PR #2570] [MERGED] fix: number sort #5306

New issue

Closed

opened 2026-03-23 22:18:09 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2570
Author: @appflowy
Created: 5/20/2023
Status: ✅ Merged
Merged: 5/21/2023
Merged by: @appflowy

Base: develop ← Head: fix/number_sort2

📝 Commits (5)

dd38b39 chore: remove sign
11f48e6 fix: sort number
304440d chore: update patch
98e4907 ci: fix dart test
ead19c9 chore: fmt

📊 Changes

23 files changed (+293 additions, -691 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_list.dart (+0 -1)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+6 -6)
📝 frontend/rust-lib/Cargo.lock (+91 -17)
📝 frontend/rust-lib/Cargo.toml (+5 -5)
📝 frontend/rust-lib/flowy-core/src/lib.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/number_entities.rs (+0 -5)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+8 -8)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+21 -41)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+45 -16)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/views.rs (+0 -23)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/format.rs (+7 -2)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_filter.rs (+4 -4)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_tests.rs (+46 -474)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option.rs (+13 -25)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option_entities.rs (+25 -29)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs (+12 -12)
📝 frontend/rust-lib/flowy-database2/src/services/group/group_util.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+1 -1)
📝 frontend/rust-lib/flowy-net/src/handlers/mod.rs (+0 -1)

...and 3 more files

📄 Description

sort by number and formatted number
support negative input in formatted number

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2570 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 5/20/2023 **Status:** ✅ Merged **Merged:** 5/21/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `fix/number_sort2` --- ### 📝 Commits (5) - [`dd38b39`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd38b39ad1ac5aa9173d432e9cb819541a8e9f76) chore: remove sign - [`11f48e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/11f48e66166a57f3de4c9b2d3cfdbf309071b483) fix: sort number - [`304440d`](https://github.com/AppFlowy-IO/AppFlowy/commit/304440de377591d8834f57953e5944451e1f1a92) chore: update patch - [`98e4907`](https://github.com/AppFlowy-IO/AppFlowy/commit/98e49076498f3d37d6a37d000df2aa85df075a85) ci: fix dart test - [`ead19c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/ead19c90211bc2fc6fcb1500922c55e7ce336980) chore: fmt ### 📊 Changes **23 files changed** (+293 additions, -691 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_list.dart` (+0 -1) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+6 -6) 📝 `frontend/rust-lib/Cargo.lock` (+91 -17) 📝 `frontend/rust-lib/Cargo.toml` (+5 -5) 📝 `frontend/rust-lib/flowy-core/src/lib.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/number_entities.rs` (+0 -5) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+8 -8) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+21 -41) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+45 -16) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/views.rs` (+0 -23) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/format.rs` (+7 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_filter.rs` (+4 -4) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_tests.rs` (+46 -474) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option.rs` (+13 -25) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option_entities.rs` (+25 -29) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs` (+12 -12) 📝 `frontend/rust-lib/flowy-database2/src/services/group/group_util.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-net/src/handlers/mod.rs` (+0 -1) _...and 3 more files_ </details> ### 📄 Description 1. sort by number and formatted number 2. support negative input in formatted number #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>