[PR #2624] [MERGED] fix: color not show issue when change cover photo color. #5336

Closed
opened 2026-03-23 22:18:17 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2624
Author: @ChiragPaneliya
Created: 5/26/2023
Status: Merged
Merged: 5/29/2023
Merged by: @LucasXu0

Base: developHead: cover_color_issue_fix


📝 Commits (2)

  • 961cd1c fixe: color not show issue when change cover photo color.
  • eb56d63 fix:added missing a required comma. and toColor() extension

📊 Changes

1 file changed (+6 additions, -8 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/change_cover_popover.dart (+6 -8)

📄 Description

#2613

now it will be look like this instead of simple white dot.

Screenshot 2023-05-26 at 9 36 54 AM

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2624 **Author:** [@ChiragPaneliya](https://github.com/ChiragPaneliya) **Created:** 5/26/2023 **Status:** ✅ Merged **Merged:** 5/29/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `develop` ← **Head:** `cover_color_issue_fix` --- ### 📝 Commits (2) - [`961cd1c`](https://github.com/AppFlowy-IO/AppFlowy/commit/961cd1cb3a29ff30766555d874cc9274db8d9e1d) fixe: color not show issue when change cover photo color. - [`eb56d63`](https://github.com/AppFlowy-IO/AppFlowy/commit/eb56d63679977577cb4eb481fa442e3a5112183e) fix:added missing a required comma. and toColor() extension ### 📊 Changes **1 file changed** (+6 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/change_cover_popover.dart` (+6 -8) </details> ### 📄 Description #2613 now it will be look like this instead of simple white dot. <img width="451" alt="Screenshot 2023-05-26 at 9 36 54 AM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/51508126/dcfc313a-6274-4c08-b149-e4779f90b322"> #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5336
No description provided.