AppFlowy-IO/AppFlowy

Fork

You've already forked AppFlowy

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

Code Issues 952 Projects Packages Wiki Activity

[PR #2670] [MERGED] [feat] Dynamically Load Themes in AppFlowy #5357

New issue

Closed

opened 2026-03-23 22:18:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:23 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2670
Author: @a-wallen
Created: 5/31/2023
Status: ✅ Merged
Merged: 7/3/2023
Merged by: @appflowy

Base: main ← Head: dynamic_theme_plugin

📝 Commits (10+)

8a1e713 feat: dynamic theme plugin (init)
a9baa2e feat: provide fallback color if plugin becomes out of date (transparent)
254749d feat: use applicationDocumentsDirectory to store plugins
5ed6b75 chore: remove json files
33bc14d fix: add toJson to resolve analyzer errors
17041ac fix: analyzer (unused imports)
1b7c83a feat: add code generation scripts for freezed files (call recursively in packages)
b57a725 fix: revert changes to dry generation
b638279 feat: call directly into script
f1d0829 refactor: scripts try to be stateless :)

📊 Changes

51 files changed (+1413 additions, -130 deletions)

View changed files

📝 frontend/.vscode/tasks.json (+21 -5)
📝 frontend/appflowy_flutter/assets/translations/en.json (+13 -1)
📝 frontend/appflowy_flutter/integration_test/util/mock/mock_file_picker.dart (+6 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker_bloc.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_selection_menu.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/user/presentation/folder/folder_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/header/import/import_panel.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+160 -46)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_file_customize_location_view.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_file_exporter_widget.dart (+2 -2)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_confirm_delete_dialog.dart (+59 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_button.dart (+41 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_decoration.dart (+40 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_failure_widget.dart (+41 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_loading_widget.dart (+34 -0)

...and 31 more files

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/2ce856ab-b5a8-4e67-8830-0c6c633446dd

Loads themes from a JSON file at runtime.

TODO

Run build_runner in flowy_infra to pass CI
Fix InvalidType build_runner errors.
Provide default values or throw an error if FlowyColorScheme API changes and the old theme is incompatible with the new API.
Load the themes from a different directory (for example, path_provider getApplicationDocumentsDirectory()).
Allow users to drag and drop themes via the GUI (in the appearance settings menu).

https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/f6d32036-73b3-4cdc-96ec-cef34b587331

Delete uploaded themes.

https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/e4b050eb-b07a-421a-88d8-fea7978877e2

~~Better prompt messages~~
~~Better error messages~~
Fix all merge conflicts from the recent merge of develop into main
Refactor (code style)
Widget/integration test for previous use cases.
Users should be able to browse available JSON themes on a website.

Issues https://github.com/AppFlowy-IO/AppFlowy/issues/1070. It does not fix but makes it easier to experiment with new themes.

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2670 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 5/31/2023 **Status:** ✅ Merged **Merged:** 7/3/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `dynamic_theme_plugin` --- ### 📝 Commits (10+) - [`8a1e713`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a1e713c0fc6b00f64b1c2598f4bd07c982ed7be) feat: dynamic theme plugin (init) - [`a9baa2e`](https://github.com/AppFlowy-IO/AppFlowy/commit/a9baa2e3b27465a758dba54c6434997c48f600aa) feat: provide fallback color if plugin becomes out of date (transparent) - [`254749d`](https://github.com/AppFlowy-IO/AppFlowy/commit/254749d159398f5a4fdf31b061a8dbdf391d7b54) feat: use applicationDocumentsDirectory to store plugins - [`5ed6b75`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ed6b75632f8da188dc6770b7be0e041601d8b6a) chore: remove json files - [`33bc14d`](https://github.com/AppFlowy-IO/AppFlowy/commit/33bc14dcf598e999b54c6020e0de93330cde7d99) fix: add toJson to resolve analyzer errors - [`17041ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/17041ac8ef67cbc27caf46c72e4d53fa74a603e5) fix: analyzer (unused imports) - [`1b7c83a`](https://github.com/AppFlowy-IO/AppFlowy/commit/1b7c83ae11fc27e9f2231df27c9bd9b9ade7a774) feat: add code generation scripts for freezed files (call recursively in packages) - [`b57a725`](https://github.com/AppFlowy-IO/AppFlowy/commit/b57a725accda839e045f7ea41dc88022bae9bb58) fix: revert changes to dry generation - [`b638279`](https://github.com/AppFlowy-IO/AppFlowy/commit/b638279d3b141759efdc15acefb007e2008628b2) feat: call directly into script - [`f1d0829`](https://github.com/AppFlowy-IO/AppFlowy/commit/f1d082968f7ab3b7ccfdf10a0c728fec110ff63c) refactor: scripts try to be stateless :) ### 📊 Changes **51 files changed** (+1413 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `frontend/.vscode/tasks.json` (+21 -5) 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+13 -1) 📝 `frontend/appflowy_flutter/integration_test/util/mock/mock_file_picker.dart` (+6 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker_bloc.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_selection_menu.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/user/presentation/folder/folder_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/header/import/import_panel.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+160 -46) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_file_customize_location_view.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_file_exporter_widget.dart` (+2 -2) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_confirm_delete_dialog.dart` (+59 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_button.dart` (+41 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_decoration.dart` (+40 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_failure_widget.dart` (+41 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_loading_widget.dart` (+34 -0) _...and 31 more files_ </details> ### 📄 Description   ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/2ce856ab-b5a8-4e67-8830-0c6c633446dd Loads themes from a JSON file at runtime. TODO - [x] Run build_runner in flowy_infra to pass CI - [x] Fix `InvalidType` build_runner errors. - [X] Provide default values or throw an error if `FlowyColorScheme` API changes and the old theme is incompatible with the new API. - [x] Load the themes from a different directory (for example, `path_provider` `getApplicationDocumentsDirectory()`). - [x] Allow users to drag and drop themes via the GUI (in the appearance settings menu). https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/f6d32036-73b3-4cdc-96ec-cef34b587331 - [x] Delete uploaded themes. https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/e4b050eb-b07a-421a-88d8-fea7978877e2 - [ ] ~Better prompt messages~ - [ ] ~Better error messages~ - [x] Fix all merge conflicts from the recent merge of `develop` into `main` - [x] Refactor (code style) - [ ] Widget/integration test for previous use cases. - [ ] Users should be able to browse available JSON themes on a website.  Issues https://github.com/AppFlowy-IO/AppFlowy/issues/1070. It does not fix but makes it easier to experiment with new themes. ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

mirror

2026-03-23 22:18:23 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

copilot/fix-date-format-issue

feat/mention_a_person

merge_upstream_v6

mobile/release/0.9.3

release/0.9.3

release/0.9.2

select_source

release/0.9.1

refactor_import_data

release/0.8.9.1

release/0.8.9

anon_user_mode

release/0.8.8

fix_windows_selection

release/0.8.7

annieappflowy-patch-1

windows_local_ai

release/0.8.6

release/0.8.5

release/0.8.4

chore/optional-response-format

release/0.8.3

release/0.8.2

release/0.8.1

release/0.8.0

release/0.7.9

feat/support-rename-workspace

chat_rag_only

calculate_ui_test

release/0.7.8

release/0.7.7

stringfi_cells

hotfix/0.7.5

release/0.7.4

client-api-update

feat/collab-editing

fix_calculation_bug

feat/upload-file-in-document

update-client-api

feat/support-global-comment-on-web

update-client-api-2

feat/support-duplicate-publish-on-web

feat/ai-plan-billing

chore/test-web-deploy

chore/enable-billing-for-testing

build/test

ai_tag_feature

chore/enable-billing-plan

feat/billing-client-windows

chore/support-openai-chat

fix/try-no-media-kit

sign-in-error-format

workspace-invite-ci-test

last-workspace

workspace-invite-wip

feat/date-text-input

appflowy_v1

0.11.1

0.11.0

0.10.9

0.11.2

0.10.7

0.10.6

0.10.5

0.11.3

0.11.4

0.10.8

0.10.4

0.10.3

0.10.2

0.10.0

0.10.1

0.9.9

0.9.8

0.9.7

0.9.5

0.9.6

0.9.4

0.9.3

0.9.2

0.9.1

0.9.0

0.8.9

0.8.8

0.8.7

0.8.6

0.8.5

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

0.7.9

0.7.8

0.7.7

0.7.6

0.7.5

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.9

0.6.8

0.6.7.2

0.6.7.1

0.6.7

0.6.6

0.6.5

0.6.4

0.6.3

0.6.2

0.6.1

v0.6.1

0.6.0

0.5.9

0.5.8

0.5.7

0.5.6

0.5.5

0.5.4

0.5.3

0.5.2

0.5.1

0.5.0

0.4.9

0.4.8

0.4.7

0.4.6

0.4.5

0.4.4

0.4.3

0.4.2

0.4.1

0.4.0

0.3.9.1

0.3.9

0.3.8

0.3.7

0.3.6

0.3.5

0.3.4

0.3.3

0.3.2

0.3.1

0.3.0

0.2.9

0.2.8

0.2.7

0.2.6

0.2.5

0.2.4

0.2.3

0.2.2

0.2.1

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.9.1

0.0.9

0.0.8.1

0.0.8

0.0.7.1

0.0.7

0.0.6.2

0.0.6.1

0.0.6

0.0.6_beta.1

0.0.5.3

0.0.5.2

0.0.5.1

0.0.5

0.0.5_beta.2

0.0.5_beta.1

0.0.4

0.0.4_beta.3

0.0.4_beta.2

0.0.4_beta.1

0.0.3

0.0.3_beta.2

0.0.3_beta.1

0.0.2

0.0.1

Labels

Clear labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Mirrored from GitHub Pull Request

No labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AppFlowy-IO/AppFlowy#5357

Reference in a new issue

Repository

AppFlowy-IO/AppFlowy

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns