[PR #2700] [MERGED] feat: clear date value #5373

Closed
opened 2026-03-23 22:18:27 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2700
Author: @dejvizelo
Created: 6/4/2023
Status: Merged
Merged: 7/31/2023
Merged by: @appflowy

Base: mainHead: 1574-clear-date-value


📝 Commits (10+)

  • d824841 chore: Add _ClearDateFieldButton
  • fb43f18 chore: Add new DateCellCalendarEvent to clear date
  • 2982e82 chore: Add grid_field_clearDate translation token
  • 93802c3 refactor: _ClearDateFieldButton -> _ClearDateButton
  • 9c40b29 fix: Fix dart(unused_element) in _ClearDateButton
  • 9a3a922 feat: Handle clearDate
  • d29f03d Revert "feat: Handle clearDate"
  • 0e8861d feat: Handle clearDate
  • 3648298 feat: Add clear_flag field
  • 974b94e feat: check clear_flag to clear date

📊 Changes

17 files changed (+187 additions, -30 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+12 -0)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+26 -17)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart (+34 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell_bloc.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+33 -4)
📝 frontend/resources/translations/en.json (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs (+3 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs (+49 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs (+12 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/database_editor.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/field_test/util.rs (+1 -0)
📝 frontend/rust-lib/flowy-test/tests/database/local_test/test.rs (+2 -0)

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/59970707/36571a12-4d59-4e30-8b14-1a18ec211f42

Close #1574

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2700 **Author:** [@dejvizelo](https://github.com/dejvizelo) **Created:** 6/4/2023 **Status:** ✅ Merged **Merged:** 7/31/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `1574-clear-date-value` --- ### 📝 Commits (10+) - [`d824841`](https://github.com/AppFlowy-IO/AppFlowy/commit/d824841628b8e3a584e958269021e1c62129f94d) chore: Add _ClearDateFieldButton - [`fb43f18`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb43f18d3a30d2b41d1bad5205f8de5465582a88) chore: Add new DateCellCalendarEvent to clear date - [`2982e82`](https://github.com/AppFlowy-IO/AppFlowy/commit/2982e8276cc9c5ed661e76439095166fba468ed2) chore: Add grid_field_clearDate translation token - [`93802c3`](https://github.com/AppFlowy-IO/AppFlowy/commit/93802c36d4e60b3ce15a9fe6fad464264391e129) refactor: _ClearDateFieldButton -> _ClearDateButton - [`9c40b29`](https://github.com/AppFlowy-IO/AppFlowy/commit/9c40b29e1839cf1661a7c45c7db913a4635f67d4) fix: Fix dart(unused_element) in _ClearDateButton - [`9a3a922`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a3a9221e9e490f6913d37204e80b87a888b728d) feat: Handle clearDate - [`d29f03d`](https://github.com/AppFlowy-IO/AppFlowy/commit/d29f03d72a6ac80a2909475971af8097b2030d9c) Revert "feat: Handle clearDate" - [`0e8861d`](https://github.com/AppFlowy-IO/AppFlowy/commit/0e8861d34abfa00ad6c453aa3286d83a59638c99) feat: Handle clearDate - [`3648298`](https://github.com/AppFlowy-IO/AppFlowy/commit/36482982cb70e24ef34050519bcf0fc9ce0ee2ae) feat: Add clear_flag field - [`974b94e`](https://github.com/AppFlowy-IO/AppFlowy/commit/974b94ef5ecd9d6463d9a66fbbcabb875a7e8452) feat: check clear_flag to clear date ### 📊 Changes **17 files changed** (+187 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+12 -0) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+26 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart` (+34 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell_bloc.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+33 -4) 📝 `frontend/resources/translations/en.json` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs` (+49 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs` (+12 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/database_editor.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/field_test/util.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-test/tests/database/local_test/test.rs` (+2 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/59970707/36571a12-4d59-4e30-8b14-1a18ec211f42 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> Close #1574 <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:27 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5373
No description provided.