[PR #2701] [MERGED] Fix create document #5374

New issue

Closed

opened 2026-03-23 22:18:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2701
Author: @LucasXu0
Created: 6/4/2023
Status: ✅ Merged
Merged: 6/5/2023
Merged by: @appflowy

Base: develop ← Head: fix_create_document

📝 Commits (10+)

85e846a fix: create a new document
10ff19c fix: the banner don't show after deleteing the page
79bc030 fix: inserting a divider through the slash menu the cursor should stay active in the next line
f67a32e fix: the overlay doesn't dismiss after selecting a page
c0b4d10 fix: typo
48bdfe6 fix: delete the page in document if it has been deleted
f656e5e chore: l10n
07cea34 chore: rename events
41cc1bc ci: rm install_diesel in ci
c5dedd4 fix: cover color not working

📊 Changes

37 files changed (+352 additions, -165 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+8 -2)
➕ frontend/appflowy_flutter/integration_test/document_test.dart (+90 -0)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/switch_folder_test.dart (+7 -7)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/launch.dart (+81 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart (+12 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart (+3 -23)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart (+11 -10)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/change_cover_popover.dart (+5 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/cover_node_widget.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/divider/divider_character_shortcut_event.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/user/application/user_service.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/user/presentation/router.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/user/presentation/skip_log_in_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/user/presentation/splash_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart (+1 -1)

...and 17 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2701 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/4/2023 **Status:** ✅ Merged **Merged:** 6/5/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `fix_create_document` --- ### 📝 Commits (10+) - [`85e846a`](https://github.com/AppFlowy-IO/AppFlowy/commit/85e846aa2664dc01550ce4738f82d55e4996f88d) fix: create a new document - [`10ff19c`](https://github.com/AppFlowy-IO/AppFlowy/commit/10ff19c9f558791ff6120e4069859521d57f0576) fix: the banner don't show after deleteing the page - [`79bc030`](https://github.com/AppFlowy-IO/AppFlowy/commit/79bc030035e22e4c65d4a5ebe46edb29ffee9aee) fix: inserting a divider through the slash menu the cursor should stay active in the next line - [`f67a32e`](https://github.com/AppFlowy-IO/AppFlowy/commit/f67a32e2bfd7122be2f9d59af46ccc43d5b3ec7d) fix: the overlay doesn't dismiss after selecting a page - [`c0b4d10`](https://github.com/AppFlowy-IO/AppFlowy/commit/c0b4d1076b0a4c101b380a26f1c35bc61cbeeb70) fix: typo - [`48bdfe6`](https://github.com/AppFlowy-IO/AppFlowy/commit/48bdfe6232193e532fb6020b060d760fadb445ca) fix: delete the page in document if it has been deleted - [`f656e5e`](https://github.com/AppFlowy-IO/AppFlowy/commit/f656e5e34da7117441bb2340c8e4d9e8d889caac) chore: l10n - [`07cea34`](https://github.com/AppFlowy-IO/AppFlowy/commit/07cea3497df55a81488d81b42d93d47b0471af45) chore: rename events - [`41cc1bc`](https://github.com/AppFlowy-IO/AppFlowy/commit/41cc1bc30da177557ee8d4147351d71c7a037472) ci: rm install_diesel in ci - [`c5dedd4`](https://github.com/AppFlowy-IO/AppFlowy/commit/c5dedd4578fe33ececb08f9d4ff6a75d4eb814bb) fix: cover color not working ### 📊 Changes **37 files changed** (+352 additions, -165 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+8 -2) ➕ `frontend/appflowy_flutter/integration_test/document_test.dart` (+90 -0) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/switch_folder_test.dart` (+7 -7) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/launch.dart` (+81 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart` (+12 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart` (+3 -23) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart` (+11 -10) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/change_cover_popover.dart` (+5 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/cover_node_widget.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/divider/divider_character_shortcut_event.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/user/application/user_service.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/user/presentation/router.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/user/presentation/skip_log_in_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/user/presentation/splash_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart` (+1 -1) _...and 17 more files_ </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>