[PR #2703] [MERGED] feat: delete the view from the db when the view is deleted #5375

Closed
opened 2026-03-23 22:18:28 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2703
Author: @appflowy
Created: 6/4/2023
Status: Merged
Merged: 6/5/2023
Merged by: @appflowy

Base: developHead: feat/delete_view_from_db


📝 Commits (1)

  • 508761b feat: delete the view from the db when the view is deleted

📊 Changes

15 files changed (+139 additions, -75 deletions)

View changed files

📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+6 -6)
📝 frontend/rust-lib/Cargo.lock (+10 -10)
📝 frontend/rust-lib/Cargo.toml (+5 -5)
📝 frontend/rust-lib/flowy-core/src/deps_resolve/folder2_deps.rs (+26 -2)
📝 frontend/rust-lib/flowy-database2/src/manager.rs (+6 -0)
📝 frontend/rust-lib/flowy-database2/src/notification.rs (+5 -0)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+9 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs (+2 -2)
📝 frontend/rust-lib/flowy-document2/src/event_handler.rs (+1 -1)
📝 frontend/rust-lib/flowy-document2/src/manager.rs (+14 -2)
📝 frontend/rust-lib/flowy-document2/tests/document/document_test.rs (+10 -9)
📝 frontend/rust-lib/flowy-folder2/src/event_handler.rs (+6 -5)
📝 frontend/rust-lib/flowy-folder2/src/manager.rs (+26 -25)
📝 frontend/rust-lib/flowy-folder2/src/view_operation.rs (+12 -6)

📄 Description

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2703 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 6/4/2023 **Status:** ✅ Merged **Merged:** 6/5/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `feat/delete_view_from_db` --- ### 📝 Commits (1) - [`508761b`](https://github.com/AppFlowy-IO/AppFlowy/commit/508761b339f6ffa4b3f3ddb5b6d2cc263adc1dba) feat: delete the view from the db when the view is deleted ### 📊 Changes **15 files changed** (+139 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+6 -6) 📝 `frontend/rust-lib/Cargo.lock` (+10 -10) 📝 `frontend/rust-lib/Cargo.toml` (+5 -5) 📝 `frontend/rust-lib/flowy-core/src/deps_resolve/folder2_deps.rs` (+26 -2) 📝 `frontend/rust-lib/flowy-database2/src/manager.rs` (+6 -0) 📝 `frontend/rust-lib/flowy-database2/src/notification.rs` (+5 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+9 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-document2/src/event_handler.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-document2/src/manager.rs` (+14 -2) 📝 `frontend/rust-lib/flowy-document2/tests/document/document_test.rs` (+10 -9) 📝 `frontend/rust-lib/flowy-folder2/src/event_handler.rs` (+6 -5) 📝 `frontend/rust-lib/flowy-folder2/src/manager.rs` (+26 -25) 📝 `frontend/rust-lib/flowy-folder2/src/view_operation.rs` (+12 -6) </details> ### 📄 Description #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:28 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5375
No description provided.