[PR #2724] [MERGED] fix: reorder view when sibling view was deleted #5390

New issue

Closed

opened 2026-03-23 22:18:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2724
Author: @appflowy
Created: 6/6/2023
Status: ✅ Merged
Merged: 6/6/2023
Merged by: @appflowy

Base: develop ← Head: fix/move_view_if_sibling_view_is_delete

📝 Commits (3)

ff43584 fix: reorder view when sibling view was deleted
d988e35 ci: fix test
a6d55a1 ci: rust fmt

📊 Changes

13 files changed (+248 additions, -83 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/application/app/app_bloc.dart (+1 -0)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+6 -6)
📝 frontend/rust-lib/Cargo.lock (+10 -10)
📝 frontend/rust-lib/Cargo.toml (+5 -5)
📝 frontend/rust-lib/flowy-core/src/deps_resolve/collab_deps.rs (+9 -1)
📝 frontend/rust-lib/flowy-database2/src/manager.rs (+0 -1)
📝 frontend/rust-lib/flowy-folder2/src/entities/view.rs (+10 -7)
📝 frontend/rust-lib/flowy-folder2/src/event_handler.rs (+1 -3)
📝 frontend/rust-lib/flowy-folder2/src/manager.rs (+87 -16)
📝 frontend/rust-lib/flowy-sqlite/migrations/2023-06-05-135652_collab_snapshot/up.sql (+2 -0)
📝 frontend/rust-lib/flowy-sqlite/src/schema.rs (+2 -0)
📝 frontend/rust-lib/flowy-test/src/lib.rs (+28 -4)
📝 frontend/rust-lib/flowy-test/tests/folder/test.rs (+87 -30)

📄 Description

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2724 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 6/6/2023 **Status:** ✅ Merged **Merged:** 6/6/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `fix/move_view_if_sibling_view_is_delete` --- ### 📝 Commits (3) - [`ff43584`](https://github.com/AppFlowy-IO/AppFlowy/commit/ff4358492ae6fbb407b0237b18fce5769f9c2659) fix: reorder view when sibling view was deleted - [`d988e35`](https://github.com/AppFlowy-IO/AppFlowy/commit/d988e35df8f4f92f7751e5bf78366113bcc6afe7) ci: fix test - [`a6d55a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6d55a1ee30ca7927a469dc119d8f9d7a9700b3d) ci: rust fmt ### 📊 Changes **13 files changed** (+248 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/application/app/app_bloc.dart` (+1 -0) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+6 -6) 📝 `frontend/rust-lib/Cargo.lock` (+10 -10) 📝 `frontend/rust-lib/Cargo.toml` (+5 -5) 📝 `frontend/rust-lib/flowy-core/src/deps_resolve/collab_deps.rs` (+9 -1) 📝 `frontend/rust-lib/flowy-database2/src/manager.rs` (+0 -1) 📝 `frontend/rust-lib/flowy-folder2/src/entities/view.rs` (+10 -7) 📝 `frontend/rust-lib/flowy-folder2/src/event_handler.rs` (+1 -3) 📝 `frontend/rust-lib/flowy-folder2/src/manager.rs` (+87 -16) 📝 `frontend/rust-lib/flowy-sqlite/migrations/2023-06-05-135652_collab_snapshot/up.sql` (+2 -0) 📝 `frontend/rust-lib/flowy-sqlite/src/schema.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-test/src/lib.rs` (+28 -4) 📝 `frontend/rust-lib/flowy-test/tests/folder/test.rs` (+87 -30) </details> ### 📄 Description #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>