[PR #2798] [MERGED] fix: unable insert a reference database #5427

Closed
opened 2026-03-23 22:18:42 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2798
Author: @LucasXu0
Created: 6/15/2023
Status: Merged
Merged: 6/15/2023
Merged by: @LucasXu0

Base: mainHead: unable_insert_reference_grid


📝 Commits (3)

  • decb571 fix: unable insert a reference database
  • b19d8b5 test: add reference database tests
  • 2ca26fb feat: set min height for document inside database

📊 Changes

16 files changed (+271 additions, -49 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/cover_image_test.dart (+1 -1)
frontend/appflowy_flutter/integration_test/document_with_database_test.dart (+110 -0)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+8 -0)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+61 -19)
frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+45 -0)
📝 frontend/appflowy_flutter/integration_test/util/util.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart (+13 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/cover_node_widget.dart (+4 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+4 -5)
📝 frontend/appflowy_flutter/pubspec.lock (+5 -6)
📝 frontend/appflowy_flutter/pubspec.yaml (+5 -5)

📄 Description

Feature Preview

closes #2799


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2798 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/15/2023 **Status:** ✅ Merged **Merged:** 6/15/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `unable_insert_reference_grid` --- ### 📝 Commits (3) - [`decb571`](https://github.com/AppFlowy-IO/AppFlowy/commit/decb571d5e3ab102fa59c0902b14c3a314944149) fix: unable insert a reference database - [`b19d8b5`](https://github.com/AppFlowy-IO/AppFlowy/commit/b19d8b57bf996a11965b1581605b3d1febe19c96) test: add reference database tests - [`2ca26fb`](https://github.com/AppFlowy-IO/AppFlowy/commit/2ca26fb500100c71d76b61c0b48a30334adf92b6) feat: set min height for document inside database ### 📊 Changes **16 files changed** (+271 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/cover_image_test.dart` (+1 -1) ➕ `frontend/appflowy_flutter/integration_test/document_with_database_test.dart` (+110 -0) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+8 -0) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+61 -19) ➕ `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+45 -0) 📝 `frontend/appflowy_flutter/integration_test/util/util.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart` (+13 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/cover_node_widget.dart` (+4 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+4 -5) 📝 `frontend/appflowy_flutter/pubspec.lock` (+5 -6) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+5 -5) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview closes #2799 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:42 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5427
No description provided.