[PR #2821] [MERGED] test: filter integration #5434

Closed
opened 2026-03-23 22:18:43 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2821
Author: @appflowy
Created: 6/16/2023
Status: Merged
Merged: 6/16/2023
Merged by: @appflowy

Base: mainHead: test/filter_integration


📝 Commits (5)

  • 2a10196 test: add checklist filter test
  • 13aeffc fix: widget reference to invalid databaseController
  • ff87986 fix: SelectOptionFilterList doesn't expand to fill the CustomScrollView
  • b4505d5 test: add single select and multi-select filter test
  • 09a8c87 ci: set protoc version

📊 Changes

10 files changed (+239 additions, -72 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_filter_test.dart (+89 -3)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+4 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+49 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart (+21 -16)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart (+50 -23)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart (+13 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/checklist/checklist.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart (+6 -8)
📝 frontend/scripts/makefile/protobuf.toml (+3 -3)

📄 Description

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2821 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/16/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `test/filter_integration` --- ### 📝 Commits (5) - [`2a10196`](https://github.com/AppFlowy-IO/AppFlowy/commit/2a101966cee53cf30471c5357010e2bfea07b7e3) test: add checklist filter test - [`13aeffc`](https://github.com/AppFlowy-IO/AppFlowy/commit/13aeffc5e335ec5aa93f468459dbbfdff0f7f5ac) fix: widget reference to invalid databaseController - [`ff87986`](https://github.com/AppFlowy-IO/AppFlowy/commit/ff87986202e0056c74b976130d232f6ddc90cafd) fix: SelectOptionFilterList doesn't expand to fill the CustomScrollView - [`b4505d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4505d583e0325ec0fcf8edd1bc136e71cdf2829) test: add single select and multi-select filter test - [`09a8c87`](https://github.com/AppFlowy-IO/AppFlowy/commit/09a8c87f823f360a10543054f580b7bc654a1051) ci: set protoc version ### 📊 Changes **10 files changed** (+239 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_filter_test.dart` (+89 -3) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+4 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+49 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart` (+21 -16) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart` (+50 -23) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart` (+13 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/checklist/checklist.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart` (+6 -8) 📝 `frontend/scripts/makefile/protobuf.toml` (+3 -3) </details> ### 📄 Description #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:43 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5434
No description provided.