[PR #2825] [MERGED] [feat] make error widget sexy #5436

New issue

Closed

opened 2026-03-23 22:18:44 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2825
Author: @a-wallen
Created: 6/17/2023
Status: ✅ Merged
Merged: 6/21/2023
Merged by: @appflowy

Base: main ← Head: error_widget

📝 Commits (10+)

aaac0dc feat: add translations
a8b52fb feat: style error page
ec33850 chore: update api usage
ab993da feat: add GitHub redirect
8d39bc7 chore: rebase error?
87d41db chore: remove todo comment
ec39821 chore: remove impossible code
fe271dd fix: update url launcher invocation
4ae0e6f chore: use new api
cb9437e fix: analyzer errors

📊 Changes

10 files changed (+240 additions, -20 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+6 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart (+16 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+16 -3)
📝 frontend/appflowy_flutter/lib/user/presentation/welcome_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/error_page.dart (+183 -3)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/pubspec.yaml (+1 -0)

📄 Description

Feature Preview

This is to style the error widget per @appflowy's request and fix my remaining TODO comment.

PR Checklist

My code adheres to the AppFlowy Style Guide
~~I've listed at least one issue this PR fixes in the description above.~~ fixing TODO
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2825 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 6/17/2023 **Status:** ✅ Merged **Merged:** 6/21/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `error_widget` --- ### 📝 Commits (10+) - [`aaac0dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/aaac0dca2e59c03f20c595c042ec3c23f0e10e50) feat: add translations - [`a8b52fb`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8b52fbf1419ba75640aa72021030ce513718f76) feat: style error page - [`ec33850`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec33850bbcc4159e06fde870f587af4d0128d68a) chore: update api usage - [`ab993da`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab993da49956582831eff95c8a265b68369914a8) feat: add GitHub redirect - [`8d39bc7`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d39bc7ce7220977d0c31d621e3f879e824495e9) chore: rebase error? - [`87d41db`](https://github.com/AppFlowy-IO/AppFlowy/commit/87d41db5f32989ee01b4372e669d20410fbfceb0) chore: remove todo comment - [`ec39821`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec39821f264160824152941f0830e1f0e8e262cf) chore: remove impossible code - [`fe271dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/fe271dd9e560b13891673b1101166fbaa5f17b75) fix: update url launcher invocation - [`4ae0e6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ae0e6fb92e82dd48dc11408e1d7b7692d050484) chore: use new api - [`cb9437e`](https://github.com/AppFlowy-IO/AppFlowy/commit/cb9437e804afa79c2237219ff8c994722354e144) fix: analyzer errors ### 📊 Changes **10 files changed** (+240 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+6 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart` (+16 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+16 -3) 📝 `frontend/appflowy_flutter/lib/user/presentation/welcome_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/error_page.dart` (+183 -3) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/pubspec.yaml` (+1 -0) </details> ### 📄 Description   ### Feature Preview ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/77ad57bb-df45-4f95-8fb7-e906e5123672)  This is to style the error widget per @appflowy's request and fix my remaining TODO comment. ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] ~I've listed at least one issue this PR fixes in the description above.~ fixing TODO - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>