[PR #2848] [MERGED] feat: customize command shortcuts #5443

New issue

Closed

opened 2026-03-23 22:18:46 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2848
Author: @MayurSMahajan
Created: 6/20/2023
Status: ✅ Merged
Merged: 7/20/2023
Merged by: @LucasXu0

Base: main ← Head: fr_customize_commands_1882

📝 Commits (10+)

df83815 feat: customize shortcuts feature
9c6f702 test: cubit service and widget test
ec39872 chore: load shortcuts during editor initialization
c9aeb03 refactor: service to move private methods to end
64a5e83 refactor: apply suggestions on service and test
618f784 refactor: apply suggestions to cubit
bf2ab9b refactor: await when loading shortcuts initially
7c3784a Merge branch 'main' into fr_customize_commands_1882
07c44b7 chore: update the name of application dir
9084c3b chore: format code

📊 Changes

15 files changed (+1253 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+23 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart (+1 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart (+124 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_service.dart (+101 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/shortcuts_model.dart (+62 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+3 -0)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart (+257 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+10 -0)
➕ frontend/appflowy_flutter/test/bloc_test/shortcuts_test/shortcuts_cubit_test.dart (+164 -0)
➕ frontend/appflowy_flutter/test/unit_test/settings/shortcuts/settings_shortcut_service_test.dart (+169 -0)
➕ frontend/appflowy_flutter/test/widget_test/workspace/settings/settings_customize_shortcuts_view_test.dart (+135 -0)
➕ frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_error_view_test.dart (+21 -0)
➕ frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_list_tile_test.dart (+94 -0)
➕ frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_list_view_test.dart (+78 -0)
📝 frontend/resources/translations/en.json (+11 -0)

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/d439c58a-d026-48d1-9f55-8c5427ceebe9

Solves #1882

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2848 **Author:** [@MayurSMahajan](https://github.com/MayurSMahajan) **Created:** 6/20/2023 **Status:** ✅ Merged **Merged:** 7/20/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fr_customize_commands_1882` --- ### 📝 Commits (10+) - [`df83815`](https://github.com/AppFlowy-IO/AppFlowy/commit/df83815ebe2f7d971303a9d2a9c69c1b9fa74419) feat: customize shortcuts feature - [`9c6f702`](https://github.com/AppFlowy-IO/AppFlowy/commit/9c6f7026aa255d8f58e683900ab43c777ef4b48a) test: cubit service and widget test - [`ec39872`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec39872a87738b03e066436e8fc717df69c77149) chore: load shortcuts during editor initialization - [`c9aeb03`](https://github.com/AppFlowy-IO/AppFlowy/commit/c9aeb03234bcbfefe2524e2bad3b22debd60ce88) refactor: service to move private methods to end - [`64a5e83`](https://github.com/AppFlowy-IO/AppFlowy/commit/64a5e833e15349aa93b5f2bbff90ebe01c2f247a) refactor: apply suggestions on service and test - [`618f784`](https://github.com/AppFlowy-IO/AppFlowy/commit/618f784c5092f2a00160e9e7996de6e7f42d506d) refactor: apply suggestions to cubit - [`bf2ab9b`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf2ab9bd310edf42df44262581afb4a6132784b4) refactor: await when loading shortcuts initially - [`7c3784a`](https://github.com/AppFlowy-IO/AppFlowy/commit/7c3784aef5db3dce3c7c4b2f7964efe66abecc5b) Merge branch 'main' into fr_customize_commands_1882 - [`07c44b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/07c44b7cc35b74d7a24ebb9bf8feb09b56ae55b7) chore: update the name of application dir - [`9084c3b`](https://github.com/AppFlowy-IO/AppFlowy/commit/9084c3bf890ff76ddb4b528601982c297fff80d7) chore: format code ### 📊 Changes **15 files changed** (+1253 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+23 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart` (+124 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_service.dart` (+101 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/shortcuts_model.dart` (+62 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+3 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart` (+257 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+10 -0) ➕ `frontend/appflowy_flutter/test/bloc_test/shortcuts_test/shortcuts_cubit_test.dart` (+164 -0) ➕ `frontend/appflowy_flutter/test/unit_test/settings/shortcuts/settings_shortcut_service_test.dart` (+169 -0) ➕ `frontend/appflowy_flutter/test/widget_test/workspace/settings/settings_customize_shortcuts_view_test.dart` (+135 -0) ➕ `frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_error_view_test.dart` (+21 -0) ➕ `frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_list_tile_test.dart` (+94 -0) ➕ `frontend/appflowy_flutter/test/widget_test/workspace/settings/shortcuts_list_view_test.dart` (+78 -0) 📝 `frontend/resources/translations/en.json` (+11 -0) </details> ### 📄 Description   ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/d439c58a-d026-48d1-9f55-8c5427ceebe9  --- Solves #1882  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>