[PR #2880] [MERGED] fix: cell focus issue on windows #5458

New issue

Closed

opened 2026-03-23 22:18:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2880
Author: @appflowy
Created: 6/22/2023
Status: ✅ Merged
Merged: 6/22/2023
Merged by: @appflowy

Base: main ← Head: fix/windows_cell_focus

📝 Commits (7)

89305cd fix: cell focus issue on windows
4c1fb05 fix: try to fix
8dbb78e fix: cell focus not working on Windows platform there are multiple text cells
da22f97 docs: add documentation
736fcb7 chore: adjust row detail page ui
f178c7b test: add test
250c6b9 test: fix test

📊 Changes

15 files changed (+169 additions, -92 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+39 -0)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+13 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart (+63 -35)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart (+15 -18)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/cell_container.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/number_cell/number_cell.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/url_cell.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+5 -4)
📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+10 -10)

📄 Description

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2880 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 6/22/2023 **Status:** ✅ Merged **Merged:** 6/22/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/windows_cell_focus` --- ### 📝 Commits (7) - [`89305cd`](https://github.com/AppFlowy-IO/AppFlowy/commit/89305cd0e9fc17d4cd6b4c89917872d6c2d7e5ee) fix: cell focus issue on windows - [`4c1fb05`](https://github.com/AppFlowy-IO/AppFlowy/commit/4c1fb0502f0685b8cea7b5473f658a408d9c1cd1) fix: try to fix - [`8dbb78e`](https://github.com/AppFlowy-IO/AppFlowy/commit/8dbb78e7398a8973661e256468cdd269bf575e57) fix: cell focus not working on Windows platform there are multiple text cells - [`da22f97`](https://github.com/AppFlowy-IO/AppFlowy/commit/da22f97c611bce3172be5db8b2b7348a163a810d) docs: add documentation - [`736fcb7`](https://github.com/AppFlowy-IO/AppFlowy/commit/736fcb73027306d5b57aaf21ffda216f24493de5) chore: adjust row detail page ui - [`f178c7b`](https://github.com/AppFlowy-IO/AppFlowy/commit/f178c7b2fb12b846c86324c15e8efd5787edea81) test: add test - [`250c6b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/250c6b93024c6661e4cfad8eb7ff6331194a612a) test: fix test ### 📊 Changes **15 files changed** (+169 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+39 -0) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+13 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart` (+63 -35) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart` (+15 -18) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/cell_container.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/number_cell/number_cell.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/url_cell.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+5 -4) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+10 -10) </details> ### 📄 Description #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>