AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #1385] [Bug] Grid URL property's edit button #546

New issue

Closed

opened 2026-03-23 20:37:44 +00:00 by mirror · 14 comments

mirror commented

2026-03-23 20:37:44 +00:00

Owner

Originally created by @richardshiue on GitHub (Oct 27, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1385

Originally assigned to: @onyicodes on GitHub.

Bug Description

In a grid with a URL property, hovering in any other field in the same row triggers the edit button to show up in the URL cell.

How to Reproduce

Go to a grid with a URL property
Hover over a row, on a property apart from the URL property
Observe that the editor URL button appears

Expected Behavior

The button should only show when the user hovers over the exact cell, not the row in general

Operating System

Fedora Linux 36

AppFlowy Version(s)

v0.0.6

Screenshots

Additional Context

No response

Originally created by @richardshiue on GitHub (Oct 27, 2022). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1385 Originally assigned to: @onyicodes on GitHub. ### Bug Description In a grid with a URL property, hovering in any other field in the same row triggers the edit button to show up in the URL cell. ### How to Reproduce 1. Go to a grid with a URL property 2. Hover over a row, on a property apart from the URL property 3. Observe that the editor URL button appears ### Expected Behavior The button should only show when the user hovers over the exact cell, not the row in general ### Operating System Fedora Linux 36 ### AppFlowy Version(s) v0.0.6 ### Screenshots ![image](https://user-images.githubusercontent.com/71320345/198276005-74a620f0-bf9c-454f-ab36-5b3af7754de3.png) ### Additional Context _No response_

mirror

2026-03-23 20:37:44 +00:00

closed this issue
added the
good first issue for devs

grid

help wanted

improvements
labels

mirror commented

2026-03-23 20:37:44 +00:00

Author

Owner

@onyicodes commented on GitHub (Oct 29, 2022):

Hi @richardshiue, I will like to work on this. Please can you assign this to me?

@onyicodes commented on GitHub (Oct 29, 2022): Hi @richardshiue, I will like to work on this. Please can you assign this to me?

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@richardshiue commented on GitHub (Oct 30, 2022):

Hello @Onyedikareal, thanks for offering to help on this! I'm not a maintainer so I can't do that for you, sorry. Ping @annieappflowy

@richardshiue commented on GitHub (Oct 30, 2022): Hello @Onyedikareal, thanks for offering to help on this! I'm not a maintainer so I can't do that for you, sorry. Ping @annieappflowy

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@onyicodes commented on GitHub (Oct 30, 2022):

Alright, thanks @richardshiue.
Hi @annieappflowy, please can you assign this to me.

@onyicodes commented on GitHub (Oct 30, 2022): Alright, thanks @richardshiue. Hi @annieappflowy, please can you assign this to me.

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@annieappflowy commented on GitHub (Nov 7, 2022):

Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you.
@richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role!

@annieappflowy commented on GitHub (Nov 7, 2022): Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you. @richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role! ![image](https://user-images.githubusercontent.com/12026239/200281294-9dd7fe53-39d4-473a-9858-b59f247339dd.png)

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@richardshiue commented on GitHub (Nov 7, 2022):

Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you. @richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role!

Thanks, that'd be an honor

@richardshiue commented on GitHub (Nov 7, 2022): > Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you. @richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role! ![image](https://user-images.githubusercontent.com/12026239/200281294-9dd7fe53-39d4-473a-9858-b59f247339dd.png) Thanks, that'd be an honor

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@onyicodes commented on GitHub (Nov 8, 2022):

Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you. @richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role!

Thanks

@onyicodes commented on GitHub (Nov 8, 2022): > Hi @Onyedikareal , thanks for offering the help. I just assigned the issue to you. @richardshiue , I've added you to our org as a collaborator. Going forward, you will be able to manage issues for AppFlowy. You should receive an invite from GitHub to accept your new role! ![image](https://user-images.githubusercontent.com/12026239/200281294-9dd7fe53-39d4-473a-9858-b59f247339dd.png) Thanks

mirror commented

2026-03-23 20:37:45 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 4, 2023):

Hey there @Onyedikareal, do you have any update on this?

@richardshiue commented on GitHub (Jan 4, 2023): Hey there @Onyedikareal, do you have any update on this?

mirror commented

2026-03-23 20:37:46 +00:00

Author

Owner

@onyicodes commented on GitHub (Jan 5, 2023):

Hi @richardshiue , thanks for asking. Unfortunately I'm hooked here. Will appreciate it if someone can assist me on this.

@onyicodes commented on GitHub (Jan 5, 2023): Hi @richardshiue , thanks for asking. Unfortunately I'm hooked here. Will appreciate it if someone can assist me on this.

mirror commented

2026-03-23 20:37:46 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 5, 2023):

Okay I'll look into it and let you know if I find something

@richardshiue commented on GitHub (Jan 5, 2023): Okay I'll look into it and let you know if I find something

mirror commented

2026-03-23 20:37:46 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 7, 2023):

Sorry I took so long to get back to you. The problem is that we want the primary cells (aka non-deletable title field) to show the open as page accessory just by hovering over it or any other cell in the row. See app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart

the onEnter stores the state of the hover event. So when a row is hovered, the cell also "gets hovered" in effect. The problem is that it's not happening only to the primary cells but the URL ones as well. So here, we should remove the update clause and replace the ChangeNotifierProxy with ChangeNotifierProvider<_CellContainerNotifier>. You can also remove rowStateNotifier field as well.

With this change primary cells won't have the previous behavior. To bring it back, we need to pass the isPrimary flag into CellContainer (I'll let you figure out from where) and then into _GridCellEnterRegion. Then, change out the Selector for a Selector2 with the selector clause being

return Selector2<RegionStateNotifier, _CellContainerNotifier, bool>(
  selector: (context, regionNotifier, cellNotifier) => !cellNotifier.isFocus && (cellNotifier.onEnter || regionNotifier.onEnter && isPrimary),
...

I think the logic is pretty self-explanatory. If you have another way fix it, feel free to submit a PR, but I think that's the gist of the problem. If you have further questions, please don't hesitate to reach out to me on the Discord server.

@richardshiue commented on GitHub (Jan 7, 2023): Sorry I took so long to get back to you. The problem is that we want the primary cells (aka non-deletable title field) to show the open as page accessory just by hovering over it or any other cell in the row. See `app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart` ![image](https://user-images.githubusercontent.com/71320345/211156478-29f7dff0-8fc4-4ccf-8ea4-42e0eaf5b395.png) the onEnter stores the state of the hover event. So when a row is hovered, the cell also "gets hovered" in effect. The problem is that it's not happening only to the primary cells but the URL ones as well. So here, we should remove the update clause and replace the `ChangeNotifierProxy` with `ChangeNotifierProvider<_CellContainerNotifier>`. You can also remove `rowStateNotifier` field as well. With this change primary cells won't have the previous behavior. To bring it back, we need to pass the `isPrimary` flag into `CellContainer` (I'll let you figure out from where) and then into `_GridCellEnterRegion`. Then, change out the `Selector` for a `Selector2` with the selector clause being ``` return Selector2<RegionStateNotifier, _CellContainerNotifier, bool>( selector: (context, regionNotifier, cellNotifier) => !cellNotifier.isFocus && (cellNotifier.onEnter || regionNotifier.onEnter && isPrimary), ... ``` I think the logic is pretty self-explanatory. If you have another way fix it, feel free to submit a PR, but I think that's the gist of the problem. If you have further questions, please don't hesitate to reach out to me on the Discord server.

mirror commented

2026-03-23 20:37:46 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 14, 2023):

@Onyedikareal gentle ping :)

@richardshiue commented on GitHub (Jan 14, 2023): @Onyedikareal gentle ping :)

mirror commented

2026-03-23 20:37:46 +00:00

Author

Owner

@onyicodes commented on GitHub (Jan 14, 2023):

@richardshiue Thanks for the gentle ping ;-) . I'm just seeing your first response. Will apply your suggestion and see if that fixes the problem.
Thanks so much.

@onyicodes commented on GitHub (Jan 14, 2023): @richardshiue Thanks for the gentle ping ;-) . I'm just seeing your first response. Will apply your suggestion and see if that fixes the problem. Thanks so much.

mirror commented

2026-03-23 20:37:47 +00:00

Author

Owner

@onyicodes commented on GitHub (Jan 16, 2023):

@richardshiue Thanks so much for the help. I've sorted this issue out with your guide.

@onyicodes commented on GitHub (Jan 16, 2023): @richardshiue Thanks so much for the help. I've sorted this issue out with your guide.

mirror commented

2026-03-23 20:37:47 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 16, 2023):

@onyicodes That's awesome! Hoping to see your PR soon

@richardshiue commented on GitHub (Jan 16, 2023): @onyicodes That's awesome! Hoping to see your PR soon

mirror referenced this issue

2026-03-23 21:36:41 +00:00

[PR #546] [MERGED] refactor: simplify launch settings #4186