[PR #2895] [MERGED] [feat] Allow user to select any Google Font #5463

New issue

Closed

opened 2026-03-23 22:18:51 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2895
Author: @a-wallen
Created: 6/24/2023
Status: ✅ Merged
Merged: 7/4/2023
Merged by: @a-wallen

Base: main ← Head: fonts

📝 Commits (10+)

ca960b3 chore: add label for font selection drop down
bf71b03 chore: add method to set font family
bf7e750 feat: add drop down to setting appearance view
5ec62fd feat: add fontFamily to document appearance cubit
667273e feat: add bloc provider to root for document appearance style
e602554 feat: syncFont family from setting appearance dialog
a84bbc1 feat: plumbing for font style in editor
8f8ee8d fix: add blocprovider before pushing overlay
24ae4c4 chore: add kv_keys
da580b1 fix: use fontFamily in document appearance cubit

📊 Changes

15 files changed (+561 additions, -95 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+4 -0)
📝 frontend/appflowy_flutter/lib/core/config/kv_keys.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+9 -27)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+35 -20)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/cubit/document_appearance_cubit.dart (+33 -10)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+24 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/menu_user.dart (+5 -1)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/levenshtein.dart (+26 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+177 -30)
➕ frontend/appflowy_flutter/test/bloc_test/app_setting_test/document_appearance_test.dart (+63 -0)
➕ frontend/appflowy_flutter/test/unit_test/algorithm/levenshtein_test.dart (+34 -0)
➕ frontend/appflowy_flutter/test/unit_test/editor/editor_style_test.dart (+46 -0)
➕ frontend/appflowy_flutter/test/widget_test/theme_font_family_setting_test.dart (+92 -0)

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/bcd8d676-954b-4e64-a36e-4bcd4e4108bc

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2795

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2895 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 7/4/2023 **Merged by:** [@a-wallen](https://github.com/a-wallen) **Base:** `main` ← **Head:** `fonts` --- ### 📝 Commits (10+) - [`ca960b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca960b30b8d15883a9161eb62b30232bb47bf5d0) chore: add label for font selection drop down - [`bf71b03`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf71b038b988a892b08d3ac54075d090cecabe7a) chore: add method to set font family - [`bf7e750`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf7e750eb6f45eed434cc7ee65f69a8caa2d33d4) feat: add drop down to setting appearance view - [`5ec62fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ec62fd9b34a66733ec70b762522b8ea141316f0) feat: add fontFamily to document appearance cubit - [`667273e`](https://github.com/AppFlowy-IO/AppFlowy/commit/667273e2f9249da9e47e4ff28350767de88704ca) feat: add bloc provider to root for document appearance style - [`e602554`](https://github.com/AppFlowy-IO/AppFlowy/commit/e602554e540878c9180475ec6cc9a5a8470f62b7) feat: syncFont family from setting appearance dialog - [`a84bbc1`](https://github.com/AppFlowy-IO/AppFlowy/commit/a84bbc1071b9e9326fac9286e2f60a260278bf46) feat: plumbing for font style in editor - [`8f8ee8d`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f8ee8d085eab4fe914e3628347469f678c021d9) fix: add blocprovider before pushing overlay - [`24ae4c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/24ae4c4afecca52a55fe9bfa0ad1a500cc50fe0d) chore: add kv_keys - [`da580b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/da580b16a7054fbc7d1544a63c099cd6f588c7e6) fix: use fontFamily in document appearance cubit ### 📊 Changes **15 files changed** (+561 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+4 -0) 📝 `frontend/appflowy_flutter/lib/core/config/kv_keys.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+9 -27) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+35 -20) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/cubit/document_appearance_cubit.dart` (+33 -10) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+24 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/menu_user.dart` (+5 -1) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/levenshtein.dart` (+26 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+177 -30) ➕ `frontend/appflowy_flutter/test/bloc_test/app_setting_test/document_appearance_test.dart` (+63 -0) ➕ `frontend/appflowy_flutter/test/unit_test/algorithm/levenshtein_test.dart` (+34 -0) ➕ `frontend/appflowy_flutter/test/unit_test/editor/editor_style_test.dart` (+46 -0) ➕ `frontend/appflowy_flutter/test/widget_test/theme_font_family_setting_test.dart` (+92 -0) </details> ### 📄 Description   ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/bcd8d676-954b-4e64-a36e-4bcd4e4108bc  fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2795 ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>