[PR #2898] [MERGED] Inline page reference #2196 #5464

New issue

Closed

opened 2026-03-23 22:18:51 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2898
Author: @rizwan3395
Created: 6/24/2023
Status: ✅ Merged
Merged: 6/29/2023
Merged by: @LucasXu0

Base: main ← Head: inline_page_reference_#2196

📝 Commits (10+)

fb71ce4 feat: inline page reference
7018002 feat: now support inline page reference
161787c Merge branch 'main' of https://github.com/rizwan3395/AppFlowy
1b5d10e chore: fixed merge issues
591019f chore: merge with main
0bebb5c chore: code improvements
b33bd3f feat: optimize the code
d700e6d test: add integration test
0dd8985 chore: update appflowy_editor
3297f1d fix: ime test

📊 Changes

15 files changed (+592 additions, -45 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart (+17 -16)
➕ frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart (+129 -0)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+17 -0)
📝 frontend/appflowy_flutter/integration_test/util/ime.dart (+13 -19)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+19 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+2 -1)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_page/inline_page_reference.dart (+164 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart (+22 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+143 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+28 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart (+13 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+3 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+3 -2)
📝 frontend/rust-lib/Cargo.lock (+10 -0)

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/47111784/339d8f80-280d-484e-9e23-cfe52bb17e45

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2898 **Author:** [@rizwan3395](https://github.com/rizwan3395) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 6/29/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `inline_page_reference_#2196` --- ### 📝 Commits (10+) - [`fb71ce4`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb71ce475d9eea1c36c61800350acd2546a7a428) feat: inline page reference - [`7018002`](https://github.com/AppFlowy-IO/AppFlowy/commit/7018002c0c3ed9f91635f4b1d46be9f4088323ca) feat: now support inline page reference - [`161787c`](https://github.com/AppFlowy-IO/AppFlowy/commit/161787cde8523291042bfeafeee472384b12d7dc) Merge branch 'main' of https://github.com/rizwan3395/AppFlowy - [`1b5d10e`](https://github.com/AppFlowy-IO/AppFlowy/commit/1b5d10e3ffec60ff8b1e7eb83f98abd806c66a3d) chore: fixed merge issues - [`591019f`](https://github.com/AppFlowy-IO/AppFlowy/commit/591019fc3ca003f60edbef35de5ee6607b58b107) chore: merge with main - [`0bebb5c`](https://github.com/AppFlowy-IO/AppFlowy/commit/0bebb5cf0784b39078cd0848be6d93d11c25a880) chore: code improvements - [`b33bd3f`](https://github.com/AppFlowy-IO/AppFlowy/commit/b33bd3f8c65d4760cd4facd4fc3e21158ab1eccd) feat: optimize the code - [`d700e6d`](https://github.com/AppFlowy-IO/AppFlowy/commit/d700e6d741fd475584d8f1087f426ba7ae5f639a) test: add integration test - [`0dd8985`](https://github.com/AppFlowy-IO/AppFlowy/commit/0dd8985dc9ce65ef1a30f33c36e905db89956a14) chore: update appflowy_editor - [`3297f1d`](https://github.com/AppFlowy-IO/AppFlowy/commit/3297f1dee1def852cc0bd6e785ad4ce8e63a2d7b) fix: ime test ### 📊 Changes **15 files changed** (+592 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart` (+17 -16) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart` (+129 -0) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+17 -0) 📝 `frontend/appflowy_flutter/integration_test/util/ime.dart` (+13 -19) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+19 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_page/inline_page_reference.dart` (+164 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart` (+22 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+143 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+28 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart` (+13 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+3 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+3 -2) 📝 `frontend/rust-lib/Cargo.lock` (+10 -0) </details> ### 📄 Description   ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/47111784/339d8f80-280d-484e-9e23-cfe52bb17e45  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>