[PR #2913] [MERGED] feat: support inserting local image #5472

Closed
opened 2026-03-23 22:18:54 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2913
Author: @LucasXu0
Created: 6/30/2023
Status: Merged
Merged: 7/2/2023
Merged by: @LucasXu0

Base: mainHead: local_image


📝 Commits (7)

  • 55b1d94 feat: support inserting local image
  • 6c8e12c feat: apply rules for transaction
  • efa8d08 feat: show a placehodler when content of outline is empty
  • cc4d05f chore: update editor version
  • 109182c fix: ci error
  • e0579d2 Merge branch 'main' into local_image
  • c7c83b7 chore: format code

📊 Changes

12 files changed (+484 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+6 -0)
📝 frontend/appflowy_flutter/integration_test/document/edit_document_test.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart (+37 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+51 -18)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_menu.dart (+290 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_selection_menu.dart (+59 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart (+10 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+11 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/cubit/document_appearance_cubit.dart (+10 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+3 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+2 -3)

📄 Description

Feature Preview

Screenshot 2023-06-30 at 14 30 10
  • support inserting local image.
  • add image menu
    • align
    • copy link
    • delete

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2913 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/30/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `local_image` --- ### 📝 Commits (7) - [`55b1d94`](https://github.com/AppFlowy-IO/AppFlowy/commit/55b1d94010b59e9f46b0a196774faf9269933fed) feat: support inserting local image - [`6c8e12c`](https://github.com/AppFlowy-IO/AppFlowy/commit/6c8e12c85e0d075f9dfd1d6c19bcc93ee15bdb98) feat: apply rules for transaction - [`efa8d08`](https://github.com/AppFlowy-IO/AppFlowy/commit/efa8d08c751151ed1f3f662d09e31766c6ce9efa) feat: show a placehodler when content of outline is empty - [`cc4d05f`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc4d05f8050f7846aaf558fe76f7b6e88a26911c) chore: update editor version - [`109182c`](https://github.com/AppFlowy-IO/AppFlowy/commit/109182c64bf3f0a641c924d87f856d387e352664) fix: ci error - [`e0579d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/e0579d2b932b4bba4e33c1336393fc7dd776a7c7) Merge branch 'main' into local_image - [`c7c83b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7c83b7853c3c6bfb6dd63258824b365be0d6352) chore: format code ### 📊 Changes **12 files changed** (+484 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+6 -0) 📝 `frontend/appflowy_flutter/integration_test/document/edit_document_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart` (+37 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+51 -18) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_menu.dart` (+290 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_selection_menu.dart` (+59 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart` (+10 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+11 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/cubit/document_appearance_cubit.dart` (+10 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+3 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+2 -3) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <img width="1246" alt="Screenshot 2023-06-30 at 14 30 10" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/d73fe2ca-40f1-4f46-a6ca-4699f8d29cde"> * support inserting local image. * add image menu * align * copy link * delete <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:54 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5472
No description provided.