[PR #2915] [MERGED] fix: trigger option selection on tap down #5473

New issue

Closed

opened 2026-03-23 22:18:54 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2915
Author: @vedant-pandey
Created: 6/30/2023
Status: ✅ Merged
Merged: 9/1/2023
Merged by: @richardshiue

Base: main ← Head: fix_select_option_tap

📝 Commits (3)

2c05715 fix: trigger option selection on tap down
805a299 chore: add TODO comment
b698a64 chore: merge remote-tracking branch 'upstream/main' into fix_select_option_tap

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart (+2 -1)

📄 Description

Closes #2832

This appears to be related to an issue in Flutter wherein onTapUp is not triggered correctly leading to onTap not firing. As a possible fix, I have moved this to use onTapDown.

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
This PR only contains semantic changes.
All existing tests are passing.

https://github.com/AppFlowy-IO/AppFlowy/assets/25723331/c052ea36-ae4b-406e-9da6-76139f9ea458

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2915 **Author:** [@vedant-pandey](https://github.com/vedant-pandey) **Created:** 6/30/2023 **Status:** ✅ Merged **Merged:** 9/1/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix_select_option_tap` --- ### 📝 Commits (3) - [`2c05715`](https://github.com/AppFlowy-IO/AppFlowy/commit/2c05715818b514b93cf1db6318073bf03563c94d) fix: trigger option selection on tap down - [`805a299`](https://github.com/AppFlowy-IO/AppFlowy/commit/805a2997388ad7f2d0b96ed396f7307abc12fbcb) chore: add TODO comment - [`b698a64`](https://github.com/AppFlowy-IO/AppFlowy/commit/b698a64f2b3433fbfc688cdfc86160641dff8dfe) chore: merge remote-tracking branch 'upstream/main' into fix_select_option_tap ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart` (+2 -1) </details> ### 📄 Description Closes #2832 This appears to be related to an [issue in Flutter](https://github.com/flutter/flutter/issues/53797) wherein onTapUp is not triggered correctly leading to onTap not firing. As a possible fix, I have moved this to use onTapDown.   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] This PR only contains semantic changes. - [x] All existing tests are passing. https://github.com/AppFlowy-IO/AppFlowy/assets/25723331/c052ea36-ae4b-406e-9da6-76139f9ea458 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>