[PR #2926] [MERGED] fix: send DidUpdateViewRows notification on create row #5480

New issue

Closed

opened 2026-03-23 22:18:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2926
Author: @zoli
Created: 7/2/2023
Status: ✅ Merged
Merged: 7/13/2023
Merged by: @appflowy

Base: main ← Head: fix/duplicate-row-adding-fields

📝 Commits (2)

c43ff50 fix: send database notification on create row
92dfd53 Merge branch 'main' into fix/duplicate-row-adding-fields

📊 Changes

1 file changed (+9 additions, -5 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+9 -5)

📄 Description

Feature Preview

Fixes #2722 the bug that Annie has mentioned in the comments.

The problem was not firing DidUpdateViewRows notification on creating row (either new row or duplicating existing row) so the row cache in view cache was not getting updated.

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2926 **Author:** [@zoli](https://github.com/zoli) **Created:** 7/2/2023 **Status:** ✅ Merged **Merged:** 7/13/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/duplicate-row-adding-fields` --- ### 📝 Commits (2) - [`c43ff50`](https://github.com/AppFlowy-IO/AppFlowy/commit/c43ff50637a6489b0e90d5d2893ba4443c6b981f) fix: send database notification on create row - [`92dfd53`](https://github.com/AppFlowy-IO/AppFlowy/commit/92dfd534b5aecdd47b5a7ba3ba16edd8b24b511d) Merge branch 'main' into fix/duplicate-row-adding-fields ### 📊 Changes **1 file changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+9 -5) </details> ### 📄 Description ### Feature Preview Fixes #2722 the bug that Annie has mentioned in the [comments](https://github.com/AppFlowy-IO/AppFlowy/issues/2722#issuecomment-1584323947). The problem was not firing `DidUpdateViewRows` notification on creating row (either new row or duplicating existing row) so the row cache in view cache was not getting updated. ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>