[PR #2941] [CLOSED] Inline math equation #5489

Closed
opened 2026-03-23 22:18:58 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2941
Author: @LucasXu0
Created: 7/5/2023
Status: Closed

Base: mainHead: inline_math_equation


📝 Commits (6)

  • 7d4fc98 chore: bump version 0.2.5 (#2924)
  • 215e450 Merge branch 'AppFlowy-IO:main' into main
  • ea1128b feat: support inline math equation
  • e376070 test: add integration test
  • 1e56c78 Merge branch 'main' into inline_math_equation
  • 31d00a1 chore: remove l10n

📊 Changes

21 files changed (+372 additions, -42 deletions)

View changed files

frontend/appflowy_flutter/assets/images/editor/math.svg (+1 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart (+72 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_1.png (+0 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_2.png (+0 -0)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+1 -15)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_popover.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_menu.dart (+1 -1)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_math_equation/inline_math_equation.dart (+173 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_math_equation/inline_math_equation_toolbar_item.dart (+50 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_page/inline_page_reference.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart (+13 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+23 -3)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/image.dart (+9 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+3 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/rust-lib/Cargo.lock (+10 -0)
📝 frontend/scripts/code_generation/freezed/generate_freezed.sh (+0 -0)

...and 1 more files

📄 Description

Feature Preview

Screenshot 2023-07-05 at 16 13 16

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2941 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/5/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `inline_math_equation` --- ### 📝 Commits (6) - [`7d4fc98`](https://github.com/AppFlowy-IO/AppFlowy/commit/7d4fc9897a7e402c47a1b2476128229eada782d3) chore: bump version 0.2.5 (#2924) - [`215e450`](https://github.com/AppFlowy-IO/AppFlowy/commit/215e4500b15268666186c3b821f61e946dc9b4c8) Merge branch 'AppFlowy-IO:main' into main - [`ea1128b`](https://github.com/AppFlowy-IO/AppFlowy/commit/ea1128ba61a70a70d942430ff677ba13ed0ee26b) feat: support inline math equation - [`e376070`](https://github.com/AppFlowy-IO/AppFlowy/commit/e37607064b776e616f65fb0b4e1329c38d20c2ae) test: add integration test - [`1e56c78`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e56c78a7ee3c3ee5b625ca64a8f6af63e7ff31b) Merge branch 'main' into inline_math_equation - [`31d00a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/31d00a1dc28cdbb5684391a61c479d6e42932978) chore: remove l10n ### 📊 Changes **21 files changed** (+372 additions, -42 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/images/editor/math.svg` (+1 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart` (+72 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_1.png` (+0 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_2.png` (+0 -0) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+1 -15) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_popover.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_menu.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_math_equation/inline_math_equation.dart` (+173 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_math_equation/inline_math_equation_toolbar_item.dart` (+50 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/inline_page/inline_page_reference.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart` (+13 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+23 -3) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/image.dart` (+9 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+3 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/rust-lib/Cargo.lock` (+10 -0) 📝 `frontend/scripts/code_generation/freezed/generate_freezed.sh` (+0 -0) _...and 1 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <img width="327" alt="Screenshot 2023-07-05 at 16 13 16" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/02b46b1c-dbdc-421b-a080-d7412fe042d2"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:58 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5489
No description provided.