[PR #2949] [MERGED] Inline math equation #5494

Closed
opened 2026-03-23 22:18:59 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2949
Author: @LucasXu0
Created: 7/6/2023
Status: Merged
Merged: 7/9/2023
Merged by: @LucasXu0

Base: mainHead: inline_math_equation


📝 Commits (10+)

  • 7d4fc98 chore: bump version 0.2.5 (#2924)
  • 215e450 Merge branch 'AppFlowy-IO:main' into main
  • 6a8fd1a fix: windows integration test
  • ea1128b feat: support inline math equation
  • e376070 test: add integration test
  • 1e56c78 Merge branch 'main' into inline_math_equation
  • 3cc8869 Merge branch 'main' into fix_windows_integration_test
  • 31d00a1 chore: remove l10n
  • 0015d74 Merge branch 'main' into inline_math_equation
  • 6fa2d3a chore: update l10n

📊 Changes

43 files changed (+500 additions, -120 deletions)

View changed files

📝 .github/workflows/flutter_ci.yaml (+1 -1)
📝 .github/workflows/integration_test.yml (+19 -18)
frontend/appflowy_flutter/assets/images/editor/math.svg (+1 -0)
📝 frontend/appflowy_flutter/assets/translations/en.json (+1 -0)
📝 frontend/appflowy_flutter/integration_test/database_calendar_test.dart (+6 -6)
📝 frontend/appflowy_flutter/integration_test/database_row_page_test.dart (+2 -1)
📝 frontend/appflowy_flutter/integration_test/database_share_test.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart (+1 -1)
frontend/appflowy_flutter/integration_test/document/document_test_runner.dart (+22 -0)
📝 frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart (+0 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart (+65 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_1.png (+0 -0)
frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_2.png (+0 -0)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+9 -16)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+25 -7)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+11 -4)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+1 -15)

...and 23 more files

📄 Description

Feature Preview

Screenshot from 2023-07-07 17-51-36

Screenshot from 2023-07-07 17-52-04


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2949 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/6/2023 **Status:** ✅ Merged **Merged:** 7/9/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `inline_math_equation` --- ### 📝 Commits (10+) - [`7d4fc98`](https://github.com/AppFlowy-IO/AppFlowy/commit/7d4fc9897a7e402c47a1b2476128229eada782d3) chore: bump version 0.2.5 (#2924) - [`215e450`](https://github.com/AppFlowy-IO/AppFlowy/commit/215e4500b15268666186c3b821f61e946dc9b4c8) Merge branch 'AppFlowy-IO:main' into main - [`6a8fd1a`](https://github.com/AppFlowy-IO/AppFlowy/commit/6a8fd1aa6b8c8358515cf2e4e71ffbc6454fb8e0) fix: windows integration test - [`ea1128b`](https://github.com/AppFlowy-IO/AppFlowy/commit/ea1128ba61a70a70d942430ff677ba13ed0ee26b) feat: support inline math equation - [`e376070`](https://github.com/AppFlowy-IO/AppFlowy/commit/e37607064b776e616f65fb0b4e1329c38d20c2ae) test: add integration test - [`1e56c78`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e56c78a7ee3c3ee5b625ca64a8f6af63e7ff31b) Merge branch 'main' into inline_math_equation - [`3cc8869`](https://github.com/AppFlowy-IO/AppFlowy/commit/3cc88691f6835162b229301861a7fc8aafd81a63) Merge branch 'main' into fix_windows_integration_test - [`31d00a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/31d00a1dc28cdbb5684391a61c479d6e42932978) chore: remove l10n - [`0015d74`](https://github.com/AppFlowy-IO/AppFlowy/commit/0015d7479cbf175facfec90a4405a64af2c04dd6) Merge branch 'main' into inline_math_equation - [`6fa2d3a`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fa2d3a62c431bf5d3a14db01aadad9195337f0f) chore: update l10n ### 📊 Changes **43 files changed** (+500 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/flutter_ci.yaml` (+1 -1) 📝 `.github/workflows/integration_test.yml` (+19 -18) ➕ `frontend/appflowy_flutter/assets/images/editor/math.svg` (+1 -0) 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+1 -0) 📝 `frontend/appflowy_flutter/integration_test/database_calendar_test.dart` (+6 -6) 📝 `frontend/appflowy_flutter/integration_test/database_row_page_test.dart` (+2 -1) 📝 `frontend/appflowy_flutter/integration_test/database_share_test.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart` (+1 -1) ➕ `frontend/appflowy_flutter/integration_test/document/document_test_runner.dart` (+22 -0) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart` (+0 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart` (+65 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_1.png` (+0 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test_2.png` (+0 -0) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+9 -16) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+25 -7) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+11 -4) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+1 -15) _...and 23 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview ![Screenshot from 2023-07-07 17-51-36](https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/5884a986-004c-4cec-94dc-1fd70779fc2d) ![Screenshot from 2023-07-07 17-52-04](https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/5d9af53e-3a35-4477-8ed2-415e1ab7d110) <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:59 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5494
No description provided.