[PR #2950] [MERGED] feat: favorites for appflowy #5495

New issue

Closed

opened 2026-03-23 22:19:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2950
Author: @squidrye
Created: 7/6/2023
Status: ✅ Merged
Merged: 8/2/2023
Merged by: @LucasXu0

Base: main ← Head: main

📝 Commits (10+)

4d01a87 feat: added service handlers for favorites
3d50a3e feat: added bloc for favorites
8aebf43 feat: added listener to observe favorites
008c097 feat: application logic of favorites
a5dd9e6 feat: added event to favorite a view
c3cf8b4 feat: setup to display favorited views
e3c1567 chore: remove redundant files
585329a feat: rust-event handlers to read, toggle favs
26407ee feat: rust-events to read, toggle favs
cd50392 feat: added rust notifiers and managers for favs

📊 Changes

50 files changed (+1268 additions, -172 deletions)

View changed files

➖ frontend/appflowy_flutter/assets/images/home/Favorite/active.svg (+0 -3)
➖ frontend/appflowy_flutter/assets/images/home/Favorite/inactive.svg (+0 -3)
📝 frontend/appflowy_flutter/assets/images/home/favorite.svg (+2 -2)
➕ frontend/appflowy_flutter/assets/images/home/unfavorite.svg (+3 -0)
➕ frontend/appflowy_flutter/integration_test/sidebar/sidebar_expand_test.dart (+48 -0)
➕ frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart (+175 -0)
📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_test_runner.dart (+4 -0)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+43 -1)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+22 -4)
📝 frontend/appflowy_flutter/lib/core/config/kv_keys.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+2 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_bloc.dart (+93 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_listener.dart (+65 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_service.dart (+18 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/favorite/prelude.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/menu/menu_bloc.dart (+2 -1)
➕ frontend/appflowy_flutter/lib/workspace/application/sidebar/folder/folder_bloc.dart (+83 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart (+21 -0)

...and 30 more files

📄 Description

Feature Preview

Edit: Here is a brief demo of what I have so far

https://github.com/AppFlowy-IO/AppFlowy/assets/84044317/36e41dd9-ffba-483d-b9ee-8822aeb0ac07

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

fixes #443
depends on https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/74

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2950 **Author:** [@squidrye](https://github.com/squidrye) **Created:** 7/6/2023 **Status:** ✅ Merged **Merged:** 8/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`4d01a87`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d01a87bcc818bf64f0d3bee57d37399837d69b2) feat: added service handlers for favorites - [`3d50a3e`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d50a3e37b491215652c59cc3a33075eb930bc96) feat: added bloc for favorites - [`8aebf43`](https://github.com/AppFlowy-IO/AppFlowy/commit/8aebf43731402d68c86d21386f504674e6b942b4) feat: added listener to observe favorites - [`008c097`](https://github.com/AppFlowy-IO/AppFlowy/commit/008c097eb71190855971b2b42fd352e05f10323c) feat: application logic of favorites - [`a5dd9e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/a5dd9e611e946e040d77d18e8e84d93168c40ae9) feat: added event to favorite a view - [`c3cf8b4`](https://github.com/AppFlowy-IO/AppFlowy/commit/c3cf8b4763833b8b7a9a43709e31d80eee158348) feat: setup to display favorited views - [`e3c1567`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3c15670ecf4c9ef23677f4129448d348ca5d8d8) chore: remove redundant files - [`585329a`](https://github.com/AppFlowy-IO/AppFlowy/commit/585329a0528c3eba20ef64100dfabf55f2a10bb6) feat: rust-event handlers to read, toggle favs - [`26407ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/26407ee9234521207ec61b11effb128d09a57c33) feat: rust-events to read, toggle favs - [`cd50392`](https://github.com/AppFlowy-IO/AppFlowy/commit/cd50392b3bdad0b8fffce8c6f9569c0802dc0f7b) feat: added rust notifiers and managers for favs ### 📊 Changes **50 files changed** (+1268 additions, -172 deletions) <details> <summary>View changed files</summary> ➖ `frontend/appflowy_flutter/assets/images/home/Favorite/active.svg` (+0 -3) ➖ `frontend/appflowy_flutter/assets/images/home/Favorite/inactive.svg` (+0 -3) 📝 `frontend/appflowy_flutter/assets/images/home/favorite.svg` (+2 -2) ➕ `frontend/appflowy_flutter/assets/images/home/unfavorite.svg` (+3 -0) ➕ `frontend/appflowy_flutter/integration_test/sidebar/sidebar_expand_test.dart` (+48 -0) ➕ `frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart` (+175 -0) 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_test_runner.dart` (+4 -0) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+43 -1) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+22 -4) 📝 `frontend/appflowy_flutter/lib/core/config/kv_keys.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+2 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_bloc.dart` (+93 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_listener.dart` (+65 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_service.dart` (+18 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/favorite/prelude.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/menu/menu_bloc.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/workspace/application/sidebar/folder/folder_bloc.dart` (+83 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart` (+21 -0) _...and 30 more files_ </details> ### 📄 Description   ### Feature Preview Edit: Here is a brief demo of what I have so far https://github.com/AppFlowy-IO/AppFlowy/assets/84044317/36e41dd9-ffba-483d-b9ee-8822aeb0ac07  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. fixes #443 depends on https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/74 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>