[PR #2973] [MERGED] fix: wrong grid row count #5504

Closed
opened 2026-03-23 22:19:02 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2973
Author: @dakaii
Created: 7/11/2023
Status: Merged
Merged: 7/13/2023
Merged by: @qinluhe

Base: mainHead: bug/grid-row-count


📝 Commits (1)

  • 91fef9e fix: wrong grid row count

📊 Changes

3 files changed (+4 additions, -14 deletions)

View changed files

📝 frontend/appflowy_tauri/src/appflowy_app/components/grid/Grid/Grid.tsx (+1 -1)
frontend/appflowy_tauri/src/appflowy_app/components/grid/GridTableCount/GridTableCount.hooks.ts (+0 -10)
📝 frontend/appflowy_tauri/src/appflowy_app/components/grid/GridTableCount/GridTableCount.tsx (+3 -3)

📄 Description

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2972

I just created a new issue and am subsequently creating a PR for it.
It's my first time contributing to this project, but I hope I'm not doing anything wrong. Let me know what you think!

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2973 **Author:** [@dakaii](https://github.com/dakaii) **Created:** 7/11/2023 **Status:** ✅ Merged **Merged:** 7/13/2023 **Merged by:** [@qinluhe](https://github.com/qinluhe) **Base:** `main` ← **Head:** `bug/grid-row-count` --- ### 📝 Commits (1) - [`91fef9e`](https://github.com/AppFlowy-IO/AppFlowy/commit/91fef9ecd052de90946da5d71f2fdb3deb5b4cba) fix: wrong grid row count ### 📊 Changes **3 files changed** (+4 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src/appflowy_app/components/grid/Grid/Grid.tsx` (+1 -1) ➖ `frontend/appflowy_tauri/src/appflowy_app/components/grid/GridTableCount/GridTableCount.hooks.ts` (+0 -10) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/grid/GridTableCount/GridTableCount.tsx` (+3 -3) </details> ### 📄 Description fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2972 --- <!--- Before you mark this PR ready for review, run through this checklist! --> I just created a new issue and am subsequently creating a PR for it. It's my first time contributing to this project, but I hope I'm not doing anything wrong. Let me know what you think! #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:02 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5504
No description provided.