[PR #3020] [MERGED] fix: focus is clickable if text field is being edited #5526

Closed
opened 2026-03-23 22:19:08 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3020
Author: @a-wallen
Created: 7/18/2023
Status: Merged
Merged: 7/18/2023
Merged by: @LucasXu0

Base: mainHead: unfocus_on_hover_fonts


📝 Commits (3)

  • 70c0928 fix: unfocus text field when user leaves to click on button
  • 325857b chore: add test
  • 3e0d4b0 chore: format code

📊 Changes

2 files changed (+54 additions, -0 deletions)

View changed files

frontend/appflowy_flutter/integration_test/appearance_settings_test.dart (+45 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+9 -0)

📄 Description

Feature Preview

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2975


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3020 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 7/18/2023 **Status:** ✅ Merged **Merged:** 7/18/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `unfocus_on_hover_fonts` --- ### 📝 Commits (3) - [`70c0928`](https://github.com/AppFlowy-IO/AppFlowy/commit/70c0928f0a231e6e51c21a3ec27b7b77c2ae689d) fix: unfocus text field when user leaves to click on button - [`325857b`](https://github.com/AppFlowy-IO/AppFlowy/commit/325857b3e148eab1ada2dd9562ab38681618da12) chore: add test - [`3e0d4b0`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e0d4b0d0fbb710969a493dd82d03ad9f23f59af) chore: format code ### 📊 Changes **2 files changed** (+54 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/appearance_settings_test.dart` (+45 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+9 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2975 --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:08 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5526
No description provided.