[PR #3050] [MERGED] fix: move translation jsons to right folder #5537

New issue

Closed

opened 2026-03-23 22:19:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3050
Author: @richardshiue
Created: 7/24/2023
Status: ✅ Merged
Merged: 8/1/2023
Merged by: @LucasXu0

Base: main ← Head: fix-translation

📝 Commits (2)

442f624 fix: move translation jsons to right folder
875cffb chore: delete translation folder before copying

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 frontend/scripts/code_generation/language_files/generate_language_files.sh (+4 -2)

📄 Description

Previously, the entire translation folder would be moved to assets/translations (i.e. assets/translations/translations/en.json) if the folder exists. This creates the folder if needed then moves the individual JSON files over instead.

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3050 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 7/24/2023 **Status:** ✅ Merged **Merged:** 8/1/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-translation` --- ### 📝 Commits (2) - [`442f624`](https://github.com/AppFlowy-IO/AppFlowy/commit/442f6248cd46accdaac3d99f611445446ba8c672) fix: move translation jsons to right folder - [`875cffb`](https://github.com/AppFlowy-IO/AppFlowy/commit/875cffb81cf4378f9778f25b3d5fd6169a395332) chore: delete translation folder before copying ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/scripts/code_generation/language_files/generate_language_files.sh` (+4 -2) </details> ### 📄 Description Previously, the entire translation folder would be moved to `assets/translations` (i.e. `assets/translations/translations/en.json`) if the folder exists. This creates the folder if needed then moves the individual JSON files over instead. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>