[PR #3083] [MERGED] feat: implement draggable folder #5553

Closed
opened 2026-03-23 22:19:15 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3083
Author: @LucasXu0
Created: 7/29/2023
Status: Merged
Merged: 7/31/2023
Merged by: @LucasXu0

Base: mainHead: draggable_nested_folder


📝 Commits (10+)

  • da7def0 feat: implement draggable folder
  • ec444e9 feat: add trash button to sidebar
  • f979692 feat: add hover color to view item
  • 923faaa Merge branch 'main' into draggable_nested_folder
  • 28b45b7 feat: update the built-in workspace view
  • 2a884f3 test: add integration test
  • f8abd40 fix: some UI issues
  • 616694b Merge remote-tracking branch 'origin/main' into draggable_nested_folder
  • 7b19035 fix: appflowy logo overflow
  • 168b9af feat: add personal header

📊 Changes

55 files changed (+2170 additions, -249 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_calendar_test.dart (+10 -9)
📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+13 -17)
📝 frontend/appflowy_flutter/integration_test/database_field_test.dart (+11 -17)
📝 frontend/appflowy_flutter/integration_test/database_filter_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/database_row_page_test.dart (+11 -20)
📝 frontend/appflowy_flutter/integration_test/database_row_test.dart (+6 -8)
📝 frontend/appflowy_flutter/integration_test/database_setting_test.dart (+3 -4)
📝 frontend/appflowy_flutter/integration_test/database_view_test.dart (+3 -6)
📝 frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart (+13 -11)
📝 frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart (+4 -4)
📝 frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart (+4 -4)
📝 frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart (+14 -8)
📝 frontend/appflowy_flutter/integration_test/document/document_with_link_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/document/document_with_outline_block_test.dart (+4 -4)
📝 frontend/appflowy_flutter/integration_test/document/document_with_toggle_list_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/document/edit_document_test.dart (+10 -4)
📝 frontend/appflowy_flutter/integration_test/import_files_test.dart (+3 -3)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+4 -0)
📝 frontend/appflowy_flutter/integration_test/share_markdown_test.dart (+9 -5)
frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart (+142 -0)

...and 35 more files

📄 Description

Feature Preview

Sidebar Structures

  • user icon, user name
  • settings
  • scrollable document list
    • favorite (wip)
    • team space files (not supported yet)
    • share files (not supported yet)
    • personal files
  • trash
  • new page button

ToDos

  • ignore moving the parent view into child view.
  • i18n and icon replacement.
  • feedback widget should contains the child view.
  • auto scroll when dragging the view.
  • save the expand status.
  • remove the readme and set the getting started view as the default view.
  • integration test.

Update

test video

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/8b3abd37-d7a9-4940-b336-2f1fdad7643a

Screenshot 2023-07-30 at 16 35 28

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ddb0d0bd-f578-4f40-afa9-338eebdc6057

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/924847de-6dde-4c89-934e-fb48c125901c


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3083 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/29/2023 **Status:** ✅ Merged **Merged:** 7/31/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `draggable_nested_folder` --- ### 📝 Commits (10+) - [`da7def0`](https://github.com/AppFlowy-IO/AppFlowy/commit/da7def01fc56d5699f2c267112e5c364828cad06) feat: implement draggable folder - [`ec444e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec444e99fecbe661bfac6257626af2eecb5a14c8) feat: add trash button to sidebar - [`f979692`](https://github.com/AppFlowy-IO/AppFlowy/commit/f979692e952c4123aa9f126e0d8b45dce7b3479a) feat: add hover color to view item - [`923faaa`](https://github.com/AppFlowy-IO/AppFlowy/commit/923faaa11198d4ed8003327a68717c8d9949d255) Merge branch 'main' into draggable_nested_folder - [`28b45b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/28b45b737dab7386fbc050c0a92dbcd69df3afd6) feat: update the built-in workspace view - [`2a884f3`](https://github.com/AppFlowy-IO/AppFlowy/commit/2a884f3ddf31b2233da6c868430f321c9a2df920) test: add integration test - [`f8abd40`](https://github.com/AppFlowy-IO/AppFlowy/commit/f8abd4095e585d0b6c4fa6b33d688c2a3f551cfc) fix: some UI issues - [`616694b`](https://github.com/AppFlowy-IO/AppFlowy/commit/616694bb8f196c72b792d99f9886477a0ccf16ff) Merge remote-tracking branch 'origin/main' into draggable_nested_folder - [`7b19035`](https://github.com/AppFlowy-IO/AppFlowy/commit/7b19035feb8ce279459aa3b95802b75b9cf2972f) fix: appflowy logo overflow - [`168b9af`](https://github.com/AppFlowy-IO/AppFlowy/commit/168b9af93df78ce806ea8d6327829814f9cd1265) feat: add personal header ### 📊 Changes **55 files changed** (+2170 additions, -249 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_calendar_test.dart` (+10 -9) 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+13 -17) 📝 `frontend/appflowy_flutter/integration_test/database_field_test.dart` (+11 -17) 📝 `frontend/appflowy_flutter/integration_test/database_filter_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/database_row_page_test.dart` (+11 -20) 📝 `frontend/appflowy_flutter/integration_test/database_row_test.dart` (+6 -8) 📝 `frontend/appflowy_flutter/integration_test/database_setting_test.dart` (+3 -4) 📝 `frontend/appflowy_flutter/integration_test/database_view_test.dart` (+3 -6) 📝 `frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart` (+13 -11) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart` (+4 -4) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_inline_math_equation_test.dart` (+4 -4) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart` (+14 -8) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_link_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_outline_block_test.dart` (+4 -4) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_toggle_list_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/document/edit_document_test.dart` (+10 -4) 📝 `frontend/appflowy_flutter/integration_test/import_files_test.dart` (+3 -3) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+4 -0) 📝 `frontend/appflowy_flutter/integration_test/share_markdown_test.dart` (+9 -5) ➕ `frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart` (+142 -0) _...and 35 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview Sidebar Structures - user icon, user name - settings - scrollable document list - favorite (wip) - team space files (not supported yet) - share files (not supported yet) - personal files - trash - new page button ToDos - [x] ignore moving the parent view into child view. - [x] i18n and icon replacement. - [x] feedback widget should contains the child view. - [x] auto scroll when dragging the view. - [x] save the expand status. - [x] remove the readme and set the getting started view as the default view. - [x] integration test. #### Update test video https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/8b3abd37-d7a9-4940-b336-2f1fdad7643a <img width="1316" alt="Screenshot 2023-07-30 at 16 35 28" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/4f02d09f-2b0d-4933-86d0-60e5844ee494"> https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ddb0d0bd-f578-4f40-afa9-338eebdc6057 https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/924847de-6dde-4c89-934e-fb48c125901c <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5553
No description provided.