[PR #3112] [MERGED] Feat: tabs shortcuts #5574

Closed
opened 2026-03-23 22:19:20 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3112
Author: @Xazin
Created: 8/3/2023
Status: Merged
Merged: 8/8/2023
Merged by: @LucasXu0

Base: mainHead: feat/gh-3100/tabs-shortcuts


📝 Commits (10+)

  • ef9f1d5 feat: ctrl + w to close current tab
  • 4972bc3 chore: add HotKeyItem for ease of adding hotkeys
  • 284a938 feat: support middle mouse click for open in tab
  • 6203989 test: amend tests for tabs
  • 8f73dcc feat: navigate between tabs using pgdn/pgup
  • adb9f1b feat: ctrl+click to open in a tab
  • e215204 test: fix tabs tests
  • be98696 chore: clean code
  • 6301c38 chore: clean code and comments
  • fba89fa Merge branch 'main' into feat/gh-3100/tabs-shortcuts

📊 Changes

26 files changed (+284 additions, -175 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_calendar_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart (+6 -6)
📝 frontend/appflowy_flutter/integration_test/document/edit_document_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/import_files_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+4 -0)
📝 frontend/appflowy_flutter/integration_test/share_markdown_test.dart (+3 -3)
📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart (+13 -13)
📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart (+7 -7)
📝 frontend/appflowy_flutter/integration_test/tabs_test.dart (+35 -23)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+16 -8)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/core/raw_keyboard_extension.dart (+8 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/menu/menu_bloc.dart (+0 -4)
📝 frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart (+16 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_event.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_state.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart (+7 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart (+86 -29)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/item.dart (+1 -6)

...and 6 more files

📄 Description

Relates: #3100 (Shortcuts)

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3112 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 8/3/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/gh-3100/tabs-shortcuts` --- ### 📝 Commits (10+) - [`ef9f1d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/ef9f1d5c3e23acf81c0b8aceaf13a7fa3427f2cb) feat: ctrl + w to close current tab - [`4972bc3`](https://github.com/AppFlowy-IO/AppFlowy/commit/4972bc3e369116beece94d8869d7bbb9dbff1955) chore: add HotKeyItem for ease of adding hotkeys - [`284a938`](https://github.com/AppFlowy-IO/AppFlowy/commit/284a938b7e2e13238cdee0180f6610d786086b02) feat: support middle mouse click for open in tab - [`6203989`](https://github.com/AppFlowy-IO/AppFlowy/commit/6203989ec73a3693169b5dff47271a5f7c955c4f) test: amend tests for tabs - [`8f73dcc`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f73dcc0eb1f53666ebe3789db835bfc411a605f) feat: navigate between tabs using pgdn/pgup - [`adb9f1b`](https://github.com/AppFlowy-IO/AppFlowy/commit/adb9f1b9737fb57b68332d005ef03c714790617e) feat: ctrl+click to open in a tab - [`e215204`](https://github.com/AppFlowy-IO/AppFlowy/commit/e215204bd1a5184d73b0919144ab7610cbcffe89) test: fix tabs tests - [`be98696`](https://github.com/AppFlowy-IO/AppFlowy/commit/be986963809cb59a3f6d9f836f1241fea07ce14b) chore: clean code - [`6301c38`](https://github.com/AppFlowy-IO/AppFlowy/commit/6301c388d2b587a3037199d5a8d07240f3e7e4fa) chore: clean code and comments - [`fba89fa`](https://github.com/AppFlowy-IO/AppFlowy/commit/fba89fa9c560af869599f68aa7e98c94ec2a5697) Merge branch 'main' into feat/gh-3100/tabs-shortcuts ### 📊 Changes **26 files changed** (+284 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_calendar_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/document/document_create_and_delete_test.dart` (+6 -6) 📝 `frontend/appflowy_flutter/integration_test/document/edit_document_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/import_files_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+4 -0) 📝 `frontend/appflowy_flutter/integration_test/share_markdown_test.dart` (+3 -3) 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart` (+13 -13) 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart` (+7 -7) 📝 `frontend/appflowy_flutter/integration_test/tabs_test.dart` (+35 -23) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+16 -8) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/core/raw_keyboard_extension.dart` (+8 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/menu/menu_bloc.dart` (+0 -4) 📝 `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart` (+16 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_event.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_state.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart` (+7 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart` (+86 -29) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/app/section/item.dart` (+1 -6) _...and 6 more files_ </details> ### 📄 Description Relates: #3100 (Shortcuts) #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5574
No description provided.