[PR #3115] [MERGED] fix: euro currency number format #5576

New issue

Closed

opened 2026-03-23 22:19:21 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3115
Author: @richardshiue
Created: 8/4/2023
Status: ✅ Merged
Merged: 8/7/2023
Merged by: @LucasXu0

Base: main ← Head: fix-#3096

📝 Commits (1)

7f40f01 fix: euro currency number format

📊 Changes

3 files changed (+21 additions, -2 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_tests.rs (+12 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option_entities.rs (+8 -1)

📄 Description

This PR saves the number as the unformatted decimal string, instead of the formatted string. This was causing problems because

1000 becomes €1.000 when stored in the backend. Then upon parsing, since . is the decimal deparator in euros, this becomes one euro and zero euro cents, which then gets formatted to €1,00.

fixes #3096

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3115 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 8/4/2023 **Status:** ✅ Merged **Merged:** 8/7/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-#3096` --- ### 📝 Commits (1) - [`7f40f01`](https://github.com/AppFlowy-IO/AppFlowy/commit/7f40f018b2aad2e37739c06df3778f37821c3597) fix: euro currency number format ### 📊 Changes **3 files changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_tests.rs` (+12 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_type_option_entities.rs` (+8 -1) </details> ### 📄 Description This PR saves the number as the unformatted decimal string, instead of the formatted string. This was causing problems because `1000` becomes `€1.000` when stored in the backend. Then upon parsing, since `.` is the decimal deparator in euros, this becomes one euro and zero euro cents, which then gets formatted to `€1,00`. fixes #3096 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>