[PR #3137] [MERGED] Reset theme buttons #5592

Closed
opened 2026-03-23 22:19:25 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3137
Author: @a-wallen
Created: 8/7/2023
Status: Merged
Merged: 8/16/2023
Merged by: @a-wallen

Base: mainHead: reset_theme_buttons


📝 Commits (10+)

  • bad357f feat: add translation for tooltip
  • cde0f74 feat: add defaults for theme settings
  • 1d124ca feat: refactor appearance view so that all theme settings can be reset
  • 66014ac chore: add keys for reset button
  • 04651a5 chore: add tests for the reset button
  • 8568a0c feat: register appearance test in runner
  • 9006e9e chore: remove comment
  • 89103c4 feat: add default file for appearance
  • e13c5a1 chore: move around files
  • a01b0f8 feat: make reset button respond to hover

📊 Changes

14 files changed (+575 additions, -416 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/appearance_settings_test.dart (+44 -1)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+13 -0)
frontend/appflowy_flutter/lib/workspace/application/appearance_defaults.dart (+10 -0)
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart (+86 -0)
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart (+175 -0)
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+144 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/levenshtein.dart (+0 -0)
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/settings_appearance.dart (+3 -0)
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/theme_setting_entry_template.dart (+89 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+4 -413)
📝 frontend/appflowy_flutter/test/unit_test/algorithm/levenshtein_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/widget_test/theme_font_family_setting_test.dart (+1 -1)
📝 frontend/resources/translations/en.json (+1 -0)

📄 Description

Feature Preview

image

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3085


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3137 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 8/7/2023 **Status:** ✅ Merged **Merged:** 8/16/2023 **Merged by:** [@a-wallen](https://github.com/a-wallen) **Base:** `main` ← **Head:** `reset_theme_buttons` --- ### 📝 Commits (10+) - [`bad357f`](https://github.com/AppFlowy-IO/AppFlowy/commit/bad357f8801c774c115a93d708f725ff69e13f57) feat: add translation for tooltip - [`cde0f74`](https://github.com/AppFlowy-IO/AppFlowy/commit/cde0f74332e4805ff5e20ef32bc25a754e2fbbd8) feat: add defaults for theme settings - [`1d124ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d124ca553aac340079599c5f52a8ce52667eb13) feat: refactor appearance view so that all theme settings can be reset - [`66014ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/66014ac71121517c3dcb7a38156d735d895c04ba) chore: add keys for reset button - [`04651a5`](https://github.com/AppFlowy-IO/AppFlowy/commit/04651a592a5620e6f5555096cf2de11bc2eed7d2) chore: add tests for the reset button - [`8568a0c`](https://github.com/AppFlowy-IO/AppFlowy/commit/8568a0c6a301ca6eef81b0bc1b430da7a59f2c82) feat: register appearance test in runner - [`9006e9e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9006e9e88d3bf8f84c7893dd245047465b38cec1) chore: remove comment - [`89103c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/89103c4df0ba1b24c08153508c55dd31f57a89a4) feat: add default file for appearance - [`e13c5a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/e13c5a1e4400f9319b8387adad9c786a908dbd40) chore: move around files - [`a01b0f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/a01b0f8d9c31d7ec5f86e7cc50fe8a87ba0f2b9d) feat: make reset button respond to hover ### 📊 Changes **14 files changed** (+575 additions, -416 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/appearance_settings_test.dart` (+44 -1) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+13 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/appearance_defaults.dart` (+10 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart` (+86 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart` (+175 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+144 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/levenshtein.dart` (+0 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/settings_appearance.dart` (+3 -0) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/theme_setting_entry_template.dart` (+89 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+4 -413) 📝 `frontend/appflowy_flutter/test/unit_test/algorithm/levenshtein_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/widget_test/theme_font_family_setting_test.dart` (+1 -1) 📝 `frontend/resources/translations/en.json` (+1 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/44445638/f5bfbafa-5a78-4aec-a98e-e025260a94ae) <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3085 --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:25 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5592
No description provided.