[PR #3141] [MERGED] fix: use dart build script on Windows #5593

New issue

Closed

opened 2026-03-23 22:19:25 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3141
Author: @a-wallen
Created: 8/8/2023
Status: ✅ Merged
Merged: 8/8/2023
Merged by: @appflowy

Base: main ← Head: remove_test_assets_windows

📝 Commits (1)

7b00377 fix: use dart build script on Windows

📊 Changes

1 file changed (+13 additions, -3 deletions)

View changed files

📝 .github/workflows/release.yml (+13 -3)

📄 Description

It was an oversight; we just forgot to call the dart build script that would clean the pubspec.yaml file before building the release version of the application.

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2914

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3141 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 8/8/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `remove_test_assets_windows` --- ### 📝 Commits (1) - [`7b00377`](https://github.com/AppFlowy-IO/AppFlowy/commit/7b003779385e651171c0d46d5865408ff7a6268e) fix: use dart build script on Windows ### 📊 Changes **1 file changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+13 -3) </details> ### 📄 Description  It was an oversight; we just forgot to call the dart build script that would clean the `pubspec.yaml` file before building the release version of the application. fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2914 ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>