[PR #3168] [MERGED] Fix windows release build #5608

New issue

Closed

opened 2026-03-23 22:19:30 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3168
Author: @a-wallen
Created: 8/11/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @LucasXu0

Base: main ← Head: fix_windows_release_build

📝 Commits (3)

682f691 refactor: build tool
38918fe chore: update release.yml
bc8981b chore: skip creating release if already created

📊 Changes

3 files changed (+63 additions, -28 deletions)

View changed files

📝 .github/workflows/release.yml (+6 -2)
📝 frontend/scripts/flutter_release_build/build_flowy.dart (+39 -12)
📝 frontend/scripts/flutter_release_build/tool.dart (+18 -14)

📄 Description

On Windows, the dart script can't invoke cargo make to build the release application because the dart script owns a file that cargo build needs. As a result, cargo build hangs, which caused the timeout seen here: https://github.com/AppFlowy-IO/AppFlowy/issues/3161

As a fix, allowed calling the two parts of the script that clean the pubspec.yaml to exclude/include test dependencies.

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3168 **Author:** [@a-wallen](https://github.com/a-wallen) **Created:** 8/11/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_windows_release_build` --- ### 📝 Commits (3) - [`682f691`](https://github.com/AppFlowy-IO/AppFlowy/commit/682f691bde73866d781202841f1253186e2e09a1) refactor: build tool - [`38918fe`](https://github.com/AppFlowy-IO/AppFlowy/commit/38918fec5256ce927fc3030517613897fc753c9f) chore: update release.yml - [`bc8981b`](https://github.com/AppFlowy-IO/AppFlowy/commit/bc8981b082812f5634a1bfd9d0610612b6eb44c2) chore: skip creating release if already created ### 📊 Changes **3 files changed** (+63 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+6 -2) 📝 `frontend/scripts/flutter_release_build/build_flowy.dart` (+39 -12) 📝 `frontend/scripts/flutter_release_build/tool.dart` (+18 -14) </details> ### 📄 Description   On Windows, the dart script can't invoke `cargo make` to build the release application because the dart script owns a file that `cargo build` needs. As a result, `cargo build` hangs, which caused the timeout seen here: https://github.com/AppFlowy-IO/AppFlowy/issues/3161 As a fix, allowed calling the two parts of the script that clean the pubspec.yaml to exclude/include test dependencies.  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>