[GH-ISSUE #1434] [Bug] NetworkType null safety issue #561

New issue

Closed

opened 2026-03-23 20:37:58 +00:00 by mirror · 1 comment

mirror commented

2026-03-23 20:37:58 +00:00

Owner

Originally created by @onyicodes on GitHub (Nov 10, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1434

Originally assigned to: @onyicodes on GitHub.

Bug Description

Connectivity result for vpn not implemented resulting to NetworkType returning null for the case where Connectivity result is vpn

How to Reproduce

Steps to reproduce

follow the contribution guideline on how to clone the repo to your local machine
follow the steps to setup your development environment
building your code will result to null safety issues relating to the NetworkType type in the file AppFlowy/frontend/app_flowy/lib/core/network_monitor.dart
If you observe properly you will see that the case for ConnectivityResult.vpn was not implemented

Expected Behavior

I expect NetworkType to return a well defined NetworkType or NetworkType.UnknownNetworkType for where NetworkType is not defined.
This will elimate the null safety issues.

Operating System

Windows

AppFlowy Version(s)

v0.0.6

Screenshots

Additional Context

No response

Originally created by @onyicodes on GitHub (Nov 10, 2022). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1434 Originally assigned to: @onyicodes on GitHub. ### Bug Description Connectivity result for vpn not implemented resulting to NetworkType returning null for the case where Connectivity result is vpn ### How to Reproduce Steps to reproduce * follow the contribution guideline on how to clone the repo to your local machine * follow the steps to setup your development environment * building your code will result to null safety issues relating to the NetworkType type in the file AppFlowy/frontend/app_flowy/lib/core/network_monitor.dart * If you observe properly you will see that the case for `ConnectivityResult.vpn` was not implemented ### Expected Behavior I expect NetworkType to return a well defined NetworkType or NetworkType.UnknownNetworkType for where NetworkType is not defined. This will elimate the null safety issues. ### Operating System Windows ### AppFlowy Version(s) v0.0.6 ### Screenshots ![image](https://user-images.githubusercontent.com/25469676/201101776-7ef0f905-88aa-4ae7-99aa-0c83513cdf43.png) ### Additional Context _No response_

mirror

2026-03-23 20:37:58 +00:00

closed this issue
added the
bug
label

mirror commented

2026-03-23 20:37:59 +00:00

Author

Owner

@richardshiue commented on GitHub (Jan 4, 2023):

With #1435 merged, I believe this issue has been fixed. Closing as completed

@richardshiue commented on GitHub (Jan 4, 2023): With #1435 merged, I believe this issue has been fixed. Closing as completed

mirror referenced this issue

2026-03-23 21:36:45 +00:00

[PR #561] [MERGED] chore(deps): bump thread_local from 1.1.3 to 1.1.4 in /frontend/rust-lib #4200