[PR #3199] [MERGED] chore: per-view field settings #5614

Closed
opened 2026-03-23 22:19:31 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3199
Author: @richardshiue
Created: 8/14/2023
Status: Merged
Merged: 8/27/2023
Merged by: @appflowy

Base: mainHead: field-settings


📝 Commits (10+)

📊 Changes

29 files changed (+737 additions, -61 deletions)

View changed files

📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+9 -9)
📝 frontend/rust-lib/Cargo.lock (+41 -20)
📝 frontend/rust-lib/Cargo.toml (+8 -8)
📝 frontend/rust-lib/flowy-database2/Cargo.toml (+2 -2)
📝 frontend/rust-lib/flowy-database2/src/entities/field_entities.rs (+7 -0)
frontend/rust-lib/flowy-database2/src/entities/field_settings_entities.rs (+118 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/macros.rs (+19 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/mod.rs (+2 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+34 -0)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+12 -0)
📝 frontend/rust-lib/flowy-database2/src/manager.rs (+11 -2)
📝 frontend/rust-lib/flowy-database2/src/notification.rs (+3 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+109 -9)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/layout_deps.rs (+5 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+43 -3)
frontend/rust-lib/flowy-database2/src/services/field_settings/entities.rs (+47 -0)
frontend/rust-lib/flowy-database2/src/services/field_settings/field_settings.rs (+35 -0)
frontend/rust-lib/flowy-database2/src/services/field_settings/field_settings_builder.rs (+42 -0)
frontend/rust-lib/flowy-database2/src/services/field_settings/mod.rs (+7 -0)
📝 frontend/rust-lib/flowy-database2/src/services/mod.rs (+1 -0)

...and 9 more files

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/87

This PR introduces the structure of the field settings in the frontend.

Each field will now be either "always shown", "hidden when empty", or "always hidden". There are also different defaults and restrictions for different layout types. In board and calendar, fields are configured to be hidden when empty by default, while in grid, fields are either always shown or always hidden

  • event handler
  • test
  • documentation

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3199 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 8/14/2023 **Status:** ✅ Merged **Merged:** 8/27/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `field-settings` --- ### 📝 Commits (10+) - [`2d08bc4`](https://github.com/AppFlowy-IO/AppFlowy/commit/2d08bc40f00ca73d41272a975b6781813b17c2d7) chore: field-setting entities-events-notifications - [`333f696`](https://github.com/AppFlowy-IO/AppFlowy/commit/333f696d6ce0e40081ee43db99c7355b383d7420) chore: update field settings - [`07f35b6`](https://github.com/AppFlowy-IO/AppFlowy/commit/07f35b693ff5e918335c4c0ce325f857b3e47a41) chore: add tests - [`43a76c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/43a76c2d388f2eddb981a61bfef8f04d3bb35b52) chore: add docs - [`6770dcc`](https://github.com/AppFlowy-IO/AppFlowy/commit/6770dcc0568d7b3ca6cb7a4bebf65d52480a1284) chore: use an enum for field visibility - [`40b111d`](https://github.com/AppFlowy-IO/AppFlowy/commit/40b111ddd902993f4cdee3a0893a68ab64069e5b) chore: clippy warnings - [`150780e`](https://github.com/AppFlowy-IO/AppFlowy/commit/150780e639dfdd9764b15af695684743edb8dce4) fix: deps fields - [`29517ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/29517ac29fd6d5a02fc18dde82983e6c66985e70) chore: collab merge main - [`b63b234`](https://github.com/AppFlowy-IO/AppFlowy/commit/b63b234aab71bbb7c7e9363c150805cb4824bc3d) chore: collab ref - [`b418a31`](https://github.com/AppFlowy-IO/AppFlowy/commit/b418a3115b3b8f54db68e1c24d6d4e0d7fa788f6) test: fix tests ### 📊 Changes **29 files changed** (+737 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+9 -9) 📝 `frontend/rust-lib/Cargo.lock` (+41 -20) 📝 `frontend/rust-lib/Cargo.toml` (+8 -8) 📝 `frontend/rust-lib/flowy-database2/Cargo.toml` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/src/entities/field_entities.rs` (+7 -0) ➕ `frontend/rust-lib/flowy-database2/src/entities/field_settings_entities.rs` (+118 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/macros.rs` (+19 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/mod.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+34 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+12 -0) 📝 `frontend/rust-lib/flowy-database2/src/manager.rs` (+11 -2) 📝 `frontend/rust-lib/flowy-database2/src/notification.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+109 -9) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/layout_deps.rs` (+5 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+43 -3) ➕ `frontend/rust-lib/flowy-database2/src/services/field_settings/entities.rs` (+47 -0) ➕ `frontend/rust-lib/flowy-database2/src/services/field_settings/field_settings.rs` (+35 -0) ➕ `frontend/rust-lib/flowy-database2/src/services/field_settings/field_settings_builder.rs` (+42 -0) ➕ `frontend/rust-lib/flowy-database2/src/services/field_settings/mod.rs` (+7 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/mod.rs` (+1 -0) _...and 9 more files_ </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/87 This PR introduces the structure of the field settings in the frontend. Each field will now be either "always shown", "hidden when empty", or "always hidden". There are also different defaults and restrictions for different layout types. In board and calendar, fields are configured to be hidden when empty by default, while in grid, fields are either always shown or always hidden - [x] event handler - [x] test - [x] documentation ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:31 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5614
No description provided.