[PR #3206] [MERGED] fix: color issues related to hover effect #5618

New issue

Closed

opened 2026-03-23 22:19:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3206
Author: @hyj1204
Created: 8/15/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @LucasXu0

Base: main ← Head: fix/hover_colors_issue

📝 Commits (8)

2216217 fix: fix hover color on information and setting button
1d43a58 chore: update the hover color of icon in SelectOptionTag
7ea68d4 chore: change hover color for add icon button
fb25d36 chore: change the SelectOptionTag text color and _SelectOptionCell icon hover color
3e2149f fix: change hover color in tab close button #3172
96361ec chore: add spacing in SelectOptionTag
bacfd51 chore: remove the hover color on close tag icon
4f24b3e chore: dart fix

📊 Changes

5 files changed (+27 additions, -20 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart (+10 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart (+3 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/icon_button.dart (+4 -5)

📄 Description

Feature Preview

Update the hover color on information and setting button
Remove the hover effect on 'x' button in SelectOptionTag
Update the hover color of _SelectOptionCell
Update the hover color on add icon button.
Fix #2790
Fix #3172

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3206 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 8/15/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/hover_colors_issue` --- ### 📝 Commits (8) - [`2216217`](https://github.com/AppFlowy-IO/AppFlowy/commit/2216217b628ceef974dc2decb99a0e5ecf08a1a9) fix: fix hover color on information and setting button - [`1d43a58`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d43a585af80efa817857566c719336d34be6e67) chore: update the hover color of icon in SelectOptionTag - [`7ea68d4`](https://github.com/AppFlowy-IO/AppFlowy/commit/7ea68d42c9d16e751f161d9817a18453f6db9f5e) chore: change hover color for add icon button - [`fb25d36`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb25d36b6f46231eccc7e6df336a55a5e70e4c01) chore: change the SelectOptionTag text color and _SelectOptionCell icon hover color - [`3e2149f`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e2149f8f6387ac707241eee6bcb8d18ddd02d08) fix: change hover color in tab close button #3172 - [`96361ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/96361ece1e056eae363eb09497ad418f01406aca) chore: add spacing in SelectOptionTag - [`bacfd51`](https://github.com/AppFlowy-IO/AppFlowy/commit/bacfd51c1180d7334b993fb77af46eb92a7fe24e) chore: remove the hover color on close tag icon - [`4f24b3e`](https://github.com/AppFlowy-IO/AppFlowy/commit/4f24b3efa20997ae118b5e5a660c0e037583fbd3) chore: dart fix ### 📊 Changes **5 files changed** (+27 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart` (+10 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart` (+3 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/icon_button.dart` (+4 -5) </details> ### 📄 Description   ### Feature Preview - Update the hover color on information and setting button <img width="341" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/c6bffb9c-dc7c-4f94-b30a-86b6898cd452"> - Remove the hover effect on 'x' button in `SelectOptionTag` <img width="320" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/6530cdd3-d896-4b5e-940a-eae706707ec8"> - Update the hover color of `_SelectOptionCell` <img width="365" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/897e75fc-6aee-45ad-8275-f4f308447ffd"> - Update the hover color on add icon button. Fix #2790 <img width="375" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/46aad511-9d26-4b8b-a179-ca6fbd1e4825"> - Fix #3172 <img width="461" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/2dcdf296-2d41-4c73-8899-b39be776ac82">  ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>