[PR #3234] [MERGED] fix: use empty event title and add placeholder #5634

Closed
opened 2026-03-23 22:19:36 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3234
Author: @richardshiue
Created: 8/18/2023
Status: Merged
Merged: 8/22/2023
Merged by: @appflowy

Base: mainHead: calendar-new-event-name


📝 Commits (5)

  • 6d4d4c7 fix: use empty event title and add placeholder
  • 33ab391 chore: update frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart
  • 494d1fe chore: remove unnecessary visible for testing
  • ce40c9c chore: apply suggestions from code review
  • fddc05f fix: typo on suggested changes

📊 Changes

8 files changed (+207 additions, -194 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_info.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart (+5 -20)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart (+1 -169)
frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart (+195 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart (+1 -1)
📝 frontend/resources/translations/en.json (+1 -0)

📄 Description

resolves https://github.com/AppFlowy-IO/AppFlowy/issues/2446

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/4d4ee2b0-36a7-45ca-b4ec-0821842a977b

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3234 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 8/18/2023 **Status:** ✅ Merged **Merged:** 8/22/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `calendar-new-event-name` --- ### 📝 Commits (5) - [`6d4d4c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/6d4d4c7753550d3570fdd45179b38533320f6253) fix: use empty event title and add placeholder - [`33ab391`](https://github.com/AppFlowy-IO/AppFlowy/commit/33ab39116aa1396743038255405d81e776b8ef5b) chore: update frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart - [`494d1fe`](https://github.com/AppFlowy-IO/AppFlowy/commit/494d1febffddd0f99f95e2f8d317863c3dff48fe) chore: remove unnecessary visible for testing - [`ce40c9c`](https://github.com/AppFlowy-IO/AppFlowy/commit/ce40c9c84b6b687694a2a68e2f925768c83f7cb5) chore: apply suggestions from code review - [`fddc05f`](https://github.com/AppFlowy-IO/AppFlowy/commit/fddc05f0be45d1481f6c0410a1ded9b7b904782a) fix: typo on suggested changes ### 📊 Changes **8 files changed** (+207 additions, -194 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_info.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart` (+5 -20) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart` (+1 -169) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart` (+195 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart` (+1 -1) 📝 `frontend/resources/translations/en.json` (+1 -0) </details> ### 📄 Description resolves https://github.com/AppFlowy-IO/AppFlowy/issues/2446 https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/4d4ee2b0-36a7-45ca-b4ec-0821842a977b ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:19:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5634
No description provided.