[PR #3362] [MERGED] fix: close popover after item selection in settings view #5694

New issue

Closed

opened 2026-03-23 22:19:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3362
Author: @vincendep
Created: 9/7/2023
Status: ✅ Merged
Merged: 9/21/2023
Merged by: @richardshiue

Base: main ← Head: fix_setting_page_3318

📝 Commits (7)

9653064 fix: close popover after item selection in settings view
3a1e4a9 fix: add missing await before closing popover
9e8524d fix: find popover container by context instead of passing controllers around
bb54eee fix: add requested changes
544e8db feat: close text direction settings popups after selection
f8932be fix: clean up
e79354d fix: restore theme value dropdown as StatefulWidget

📊 Changes

5 files changed (+27 additions, -9 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart (+7 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart (+8 -4)

📄 Description

Feature Preview

closes #3318

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3362 **Author:** [@vincendep](https://github.com/vincendep) **Created:** 9/7/2023 **Status:** ✅ Merged **Merged:** 9/21/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix_setting_page_3318` --- ### 📝 Commits (7) - [`9653064`](https://github.com/AppFlowy-IO/AppFlowy/commit/96530643ede0faeb8af57b41153a26f77789a63c) fix: close popover after item selection in settings view - [`3a1e4a9`](https://github.com/AppFlowy-IO/AppFlowy/commit/3a1e4a979e8c147446c2a3862c7c5258754d3578) fix: add missing await before closing popover - [`9e8524d`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e8524ddbc701eeb757cc64c3f319541e9fef5ef) fix: find popover container by context instead of passing controllers around - [`bb54eee`](https://github.com/AppFlowy-IO/AppFlowy/commit/bb54eee7e22d17cf93bd19691a2308601cb48aab) fix: add requested changes - [`544e8db`](https://github.com/AppFlowy-IO/AppFlowy/commit/544e8db0c4d539563dbd6c913719dd0950d21af5) feat: close text direction settings popups after selection - [`f8932be`](https://github.com/AppFlowy-IO/AppFlowy/commit/f8932becd25fb1cf9ac81f8e731a1935c5cea13e) fix: clean up - [`e79354d`](https://github.com/AppFlowy-IO/AppFlowy/commit/e79354dd8579ca50565498ff7bf2c8e65e97cd16) fix: restore theme value dropdown as StatefulWidget ### 📊 Changes **5 files changed** (+27 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart` (+7 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart` (+8 -4) </details> ### 📄 Description   ### Feature Preview  closes #3318 ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>