[PR #3369] [MERGED] feat: add end date to time cell data #5695

New issue

Closed

opened 2026-03-23 22:19:54 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3369
Author: @richardshiue
Created: 9/9/2023
Status: ✅ Merged
Merged: 9/19/2023
Merged by: @appflowy

Base: main ← Head: end-date-time

📝 Commits (8)

a96c7c8 feat: add end date to time cell data
44590cf feat: implement ui for end time
caa120a test: add date to text test
bd39fe7 chore: clippy warnings
52b2320 fix: unexpected time parsing
cf35263 fix: fix the date logic when toggling end date
a7e8bf3 chore: Merge branch 'main' into end-date-time
34b97f8 chore: Merge branch 'main' into end-date-time

📊 Changes

21 files changed (+629 additions, -124 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+12 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/date_cell_service.dart (+12 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/bloc/date_card_cell_bloc.dart (+12 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart (+119 -48)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell_bloc.dart (+12 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+130 -22)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+6 -1)
📝 frontend/resources/translations/en.json (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs (+22 -1)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+3 -0)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+1 -2)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs (+151 -21)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs (+70 -13)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+38 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_tests.rs (+26 -0)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs (+6 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/database_editor.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/field_test/util.rs (+3 -0)

...and 1 more files

📄 Description

This PR allows date ranges to be added to date cells. PREVIEW tbd

resolves #2379
resolves #2155
resolves #1546

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3369 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/9/2023 **Status:** ✅ Merged **Merged:** 9/19/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `end-date-time` --- ### 📝 Commits (8) - [`a96c7c8`](https://github.com/AppFlowy-IO/AppFlowy/commit/a96c7c87450e3c9bfe9be70497edefaa318555e6) feat: add end date to time cell data - [`44590cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/44590cfe3865179a7726bd3cc6eed6b8dd09876b) feat: implement ui for end time - [`caa120a`](https://github.com/AppFlowy-IO/AppFlowy/commit/caa120a18c05302758e362829e10b66d64ec8f7d) test: add date to text test - [`bd39fe7`](https://github.com/AppFlowy-IO/AppFlowy/commit/bd39fe779fa2ecbd3aef40f704b8fc44c69dc62a) chore: clippy warnings - [`52b2320`](https://github.com/AppFlowy-IO/AppFlowy/commit/52b23203694f901852eac4ffa4fa87c56763d648) fix: unexpected time parsing - [`cf35263`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf35263d72d070160bd2a44ddc19397052b5e47e) fix: fix the date logic when toggling end date - [`a7e8bf3`](https://github.com/AppFlowy-IO/AppFlowy/commit/a7e8bf397f97328aa41bb054f4d882e08ad06a00) chore: Merge branch 'main' into end-date-time - [`34b97f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/34b97f8f35cf613fdea4199ee3a5db18446edef5) chore: Merge branch 'main' into end-date-time ### 📊 Changes **21 files changed** (+629 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+12 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/date_cell_service.dart` (+12 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/bloc/date_card_cell_bloc.dart` (+12 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart` (+119 -48) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell_bloc.dart` (+12 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+130 -22) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+6 -1) 📝 `frontend/resources/translations/en.json` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs` (+22 -1) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+1 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs` (+151 -21) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs` (+70 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+38 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_tests.rs` (+26 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs` (+6 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/database_editor.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/field_test/util.rs` (+3 -0) _...and 1 more files_ </details> ### 📄 Description This PR allows date ranges to be added to date cells. PREVIEW tbd resolves #2379 resolves #2155 resolves #1546 ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>