[PR #3394] [CLOSED] chore: upgrade to flutter 3.13.0 #5709

New issue

Closed

opened 2026-03-23 22:19:57 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3394
Author: @LucasXu0
Created: 9/13/2023
Status: ❌ Closed

Base: main ← Head: upgrade_flutter_3130

📝 Commits (10+)

f1ed66b fix: missing a required trailing comma
76f37e1 feat: support customizing the rename dialog when creating view
e5617dd fix: scroll animation of outline is too slow
9de959b fix: align toolbar item color and size doesn't match the theme
599da94 chore: upgrade editor version
40eac42 chore: upgrade CI flutter version to 3.13.0
cbd5f75 Update frontend/appflowy_flutter/lib/workspace/application/settings/create_file_settings_cubit.dart
d042d8b feat: add more flutter linter rules
80554b8 chore: format code
1605463 Merge branch 'main' into upgrade_flutter_3130

📊 Changes

200 files changed (+933 additions, -764 deletions)

View changed files

📝 .github/workflows/flutter_ci.yaml (+1 -1)
📝 .github/workflows/integration_test.yml (+1 -1)
📝 .github/workflows/release.yml (+2 -2)
📝 .github/workflows/rust_coverage.yml (+1 -1)
📝 frontend/appflowy_flutter/README.md (+1 -1)
📝 frontend/appflowy_flutter/analysis_options.yaml (+10 -0)
📝 frontend/appflowy_flutter/integration_test/appearance_settings_test.dart (+2 -1)
📝 frontend/appflowy_flutter/integration_test/database_share_test.dart (+3 -3)
📝 frontend/appflowy_flutter/integration_test/document/document_copy_and_paste_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+3 -0)
📝 frontend/appflowy_flutter/integration_test/util/mock/mock_openai_repository.dart (+8 -3)
📝 frontend/appflowy_flutter/lib/core/config/kv.dart (+28 -0)
📝 frontend/appflowy_flutter/lib/core/config/kv_keys.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/core/frameless_window.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/core/notification/document_notification.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/core/notification/folder_notification.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/core/notification/grid_notification.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/core/notification/user_notification.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/mobile_home_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/blank/blank.dart (+6 -6)

...and 80 more files

📄 Description

Feature Preview

upgrade flutter to 3.13.0
fix some ui issues

the text-align toolbar item is too small.
before
Screenshot 2023-09-13 at 16 54 11
after
Screenshot 2023-09-13 at 17 09 21

the scroll behavior of the outline plugin is too slow.

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/01462718-769a-4da9-9257-140a6e0d8be4

add a configuration to control whether to show the rename dialog when creating a view or not.
Screenshot 2023-09-13 at 22 06 11

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3394 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `upgrade_flutter_3130` --- ### 📝 Commits (10+) - [`f1ed66b`](https://github.com/AppFlowy-IO/AppFlowy/commit/f1ed66bab38fd28033731220caa5c4326ce0c8f7) fix: missing a required trailing comma - [`76f37e1`](https://github.com/AppFlowy-IO/AppFlowy/commit/76f37e1879d0d40c5a2a4b33849b29ea10b37b38) feat: support customizing the rename dialog when creating view - [`e5617dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5617ddd4ed1a3ca9b60062210d11310d0974ae1) fix: scroll animation of outline is too slow - [`9de959b`](https://github.com/AppFlowy-IO/AppFlowy/commit/9de959b16dc4d871dfec9c194e21a80af6e3561d) fix: align toolbar item color and size doesn't match the theme - [`599da94`](https://github.com/AppFlowy-IO/AppFlowy/commit/599da943d754b81b2e1df087356dee60e92870f8) chore: upgrade editor version - [`40eac42`](https://github.com/AppFlowy-IO/AppFlowy/commit/40eac42916b45f882f4261203b1177d2cca26bb6) chore: upgrade CI flutter version to 3.13.0 - [`cbd5f75`](https://github.com/AppFlowy-IO/AppFlowy/commit/cbd5f754daacc701ac014b5e1785af9587bf1640) Update frontend/appflowy_flutter/lib/workspace/application/settings/create_file_settings_cubit.dart - [`d042d8b`](https://github.com/AppFlowy-IO/AppFlowy/commit/d042d8bf643c7c07c8e012396841ffe51923dfa0) feat: add more flutter linter rules - [`80554b8`](https://github.com/AppFlowy-IO/AppFlowy/commit/80554b8d70fc6d317309d9616afb104c0254bab3) chore: format code - [`1605463`](https://github.com/AppFlowy-IO/AppFlowy/commit/160546388c25f5f3355792dd2d86d4af5cc25d94) Merge branch 'main' into upgrade_flutter_3130 ### 📊 Changes **200 files changed** (+933 additions, -764 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/flutter_ci.yaml` (+1 -1) 📝 `.github/workflows/integration_test.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+2 -2) 📝 `.github/workflows/rust_coverage.yml` (+1 -1) 📝 `frontend/appflowy_flutter/README.md` (+1 -1) 📝 `frontend/appflowy_flutter/analysis_options.yaml` (+10 -0) 📝 `frontend/appflowy_flutter/integration_test/appearance_settings_test.dart` (+2 -1) 📝 `frontend/appflowy_flutter/integration_test/database_share_test.dart` (+3 -3) 📝 `frontend/appflowy_flutter/integration_test/document/document_copy_and_paste_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+3 -0) 📝 `frontend/appflowy_flutter/integration_test/util/mock/mock_openai_repository.dart` (+8 -3) 📝 `frontend/appflowy_flutter/lib/core/config/kv.dart` (+28 -0) 📝 `frontend/appflowy_flutter/lib/core/config/kv_keys.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/core/frameless_window.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/core/notification/document_notification.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/core/notification/folder_notification.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/core/notification/grid_notification.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/core/notification/user_notification.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/mobile_home_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/blank/blank.dart` (+6 -6) _...and 80 more files_ </details> ### 📄 Description   ### Feature Preview  - upgrade flutter to 3.13.0 - fix some ui issues the text-align toolbar item is too small. before <img width="153" alt="Screenshot 2023-09-13 at 16 54 11" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ef691d68-3fcf-4c23-9b0d-6dcc1908bb1e"> after <img width="130" alt="Screenshot 2023-09-13 at 17 09 21" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/a46e9177-43f8-4664-b20d-994c80eae172"> the scroll behavior of the outline plugin is too slow. https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/01462718-769a-4da9-9257-140a6e0d8be4 add a configuration to control whether to show the rename dialog when creating a view or not. <img width="765" alt="Screenshot 2023-09-13 at 22 06 11" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/de2b8272-c33f-49ed-a5c4-d5a1412a9966"> ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>