[PR #3399] [MERGED] fix: fix alignment issue in login page #5714

New issue

Closed

opened 2026-03-23 22:19:58 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3399
Author: @hyj1204
Created: 9/13/2023
Status: ✅ Merged
Merged: 9/15/2023
Merged by: @LucasXu0

Base: main ← Head: fix/alignment_issue_in_login_page

📝 Commits (2)

4af08b6 fix: fix alignment issue in login page
a168bb5 refactor: refactor ThirdPartySignInButtons

📊 Changes

3 files changed (+41 additions, -81 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/mobile_sign_in_screen.dart (+6 -6)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/third_party_sign_in_buttons.dart (+33 -71)
📝 frontend/appflowy_flutter/lib/user/presentation/widgets/auth_form_container.dart (+2 -4)

📄 Description

Feature Preview

In #3217, I used the wrong size(screen size) as the button size to render the button. This PR is to fix that problem. It should stay in the central position no matter how we resize the screen.

Desktop

Mobile

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3399 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 9/13/2023 **Status:** ✅ Merged **Merged:** 9/15/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/alignment_issue_in_login_page` --- ### 📝 Commits (2) - [`4af08b6`](https://github.com/AppFlowy-IO/AppFlowy/commit/4af08b61f34865bdd313534ba15493008f68af08) fix: fix alignment issue in login page - [`a168bb5`](https://github.com/AppFlowy-IO/AppFlowy/commit/a168bb5786c1485874e2c1c16b718acb2714a0d0) refactor: refactor ThirdPartySignInButtons ### 📊 Changes **3 files changed** (+41 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/mobile_sign_in_screen.dart` (+6 -6) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/third_party_sign_in_buttons.dart` (+33 -71) 📝 `frontend/appflowy_flutter/lib/user/presentation/widgets/auth_form_container.dart` (+2 -4) </details> ### 📄 Description   ### Feature Preview In #3217, I used the wrong size(screen size) as the button size to render the button. This PR is to fix that problem. It should stay in the central position no matter how we resize the screen. Desktop <img width="1774" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/dfcdcc01-7362-4e38-ada1-7363c2c8b7b8"> Mobile <img width="369" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/971a8282-9c61-409a-b5f1-6c6cab7a7d0a">  ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>