[PR #3401] [MERGED] fix: some UI issues were present in version 0.3.1. #5716

New issue

Closed

opened 2026-03-23 22:19:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3401
Author: @LucasXu0
Created: 9/14/2023
Status: ✅ Merged
Merged: 9/14/2023
Merged by: @LucasXu0

Base: main ← Head: fix_031_issues

📝 Commits (10+)

f1ed66b fix: missing a required trailing comma
76f37e1 feat: support customizing the rename dialog when creating view
e5617dd fix: scroll animation of outline is too slow
9de959b fix: align toolbar item color and size doesn't match the theme
636bb8e Revert "fix: missing a required trailing comma"
b75a299 chore: code format
d41940f Merge branch 'main' into fix_031_issues
411cd2f fix: integration test
e7c92df chore: disable log when turn off debug log flag
8b14bd5 feat: save the previous status for file settings

📊 Changes

21 files changed (+292 additions, -83 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart (+3 -5)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+26 -3)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+11 -1)
📝 frontend/appflowy_flutter/lib/core/config/kv.dart (+28 -0)
📝 frontend/appflowy_flutter/lib/core/config/kv_keys.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_button.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/align_toolbar_item.dart (+44 -22)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart (+7 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+4 -1)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/create_file_settings_cubit.dart (+29 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/prelude.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart (+8 -8)
➕ frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/rename_view_dialog.dart (+35 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_new_page_button.dart (+12 -16)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+8 -8)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/create_file_setting.dart (+37 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/dialog/styled_dialogs.dart (+4 -3)
📝 frontend/appflowy_flutter/pubspec.lock (+10 -2)

...and 1 more files

📄 Description

Feature Preview

fix some ui issues

the text-align toolbar item is too small.
before
Screenshot 2023-09-13 at 16 54 11
after
Screenshot 2023-09-13 at 17 09 21

the scroll behavior of the outline plugin is too slow.

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/01462718-769a-4da9-9257-140a6e0d8be4

add a configuration to control whether to show the rename dialog when creating a view or not.
Screenshot 2023-09-13 at 22 06 11

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3401 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/14/2023 **Status:** ✅ Merged **Merged:** 9/14/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_031_issues` --- ### 📝 Commits (10+) - [`f1ed66b`](https://github.com/AppFlowy-IO/AppFlowy/commit/f1ed66bab38fd28033731220caa5c4326ce0c8f7) fix: missing a required trailing comma - [`76f37e1`](https://github.com/AppFlowy-IO/AppFlowy/commit/76f37e1879d0d40c5a2a4b33849b29ea10b37b38) feat: support customizing the rename dialog when creating view - [`e5617dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5617ddd4ed1a3ca9b60062210d11310d0974ae1) fix: scroll animation of outline is too slow - [`9de959b`](https://github.com/AppFlowy-IO/AppFlowy/commit/9de959b16dc4d871dfec9c194e21a80af6e3561d) fix: align toolbar item color and size doesn't match the theme - [`636bb8e`](https://github.com/AppFlowy-IO/AppFlowy/commit/636bb8ea3eb3923c9dfd61a3da841b0a079b7e61) Revert "fix: missing a required trailing comma" - [`b75a299`](https://github.com/AppFlowy-IO/AppFlowy/commit/b75a29960fc11da42290731241bfb3e130cb2588) chore: code format - [`d41940f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d41940ff0b0b1e9358b5bfb03f2abbddd7ee7631) Merge branch 'main' into fix_031_issues - [`411cd2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/411cd2fb96b6014c888ffbfe6ade164a182b5773) fix: integration test - [`e7c92df`](https://github.com/AppFlowy-IO/AppFlowy/commit/e7c92dfa855114c0ac8c8797a44b5600a44e6828) chore: disable log when turn off debug log flag - [`8b14bd5`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b14bd5e698a9648a9aa29c03674cb276e003188) feat: save the previous status for file settings ### 📊 Changes **21 files changed** (+292 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_test.dart` (+3 -5) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+26 -3) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+11 -1) 📝 `frontend/appflowy_flutter/lib/core/config/kv.dart` (+28 -0) 📝 `frontend/appflowy_flutter/lib/core/config/kv_keys.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_button.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/align_toolbar_item.dart` (+44 -22) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart` (+7 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+4 -1) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/create_file_settings_cubit.dart` (+29 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/prelude.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart` (+8 -8) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/rename_view_dialog.dart` (+35 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_new_page_button.dart` (+12 -16) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+8 -8) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/create_file_setting.dart` (+37 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/dialog/styled_dialogs.dart` (+4 -3) 📝 `frontend/appflowy_flutter/pubspec.lock` (+10 -2) _...and 1 more files_ </details> ### 📄 Description   ### Feature Preview  - fix some ui issues the text-align toolbar item is too small. before <img width="153" alt="Screenshot 2023-09-13 at 16 54 11" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ef691d68-3fcf-4c23-9b0d-6dcc1908bb1e"> after <img width="130" alt="Screenshot 2023-09-13 at 17 09 21" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/a46e9177-43f8-4664-b20d-994c80eae172"> the scroll behavior of the outline plugin is too slow. https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/01462718-769a-4da9-9257-140a6e0d8be4 add a configuration to control whether to show the rename dialog when creating a view or not. <img width="765" alt="Screenshot 2023-09-13 at 22 06 11" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/de2b8272-c33f-49ed-a5c4-d5a1412a9966"> ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>