[PR #3410] [MERGED] fix: cannot open popovers #5718

New issue

Closed

opened 2026-03-23 22:19:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:19:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3410
Author: @richardshiue
Created: 9/15/2023
Status: ✅ Merged
Merged: 9/15/2023
Merged by: @richardshiue

Base: main ← Head: popover-regression

📝 Commits (1)

d7c86ed fix: cannot open popovers

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+2 -2)

📄 Description

The popovers in settings (Theme, Language, perhaps more) cannot trigger by clicking. This is a major regression from this PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3380

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3410 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/15/2023 **Status:** ✅ Merged **Merged:** 9/15/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `popover-regression` --- ### 📝 Commits (1) - [`d7c86ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7c86ed2d0ef8caecdc94cb195362673a6c3777a) fix: cannot open popovers ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+2 -2) </details> ### 📄 Description The popovers in settings (Theme, Language, perhaps more) cannot trigger by clicking. This is a major regression from this PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3380 ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>