[PR #3418] [MERGED] chore: checklist ux flow redesign #5722

Closed
opened 2026-03-23 22:20:01 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3418
Author: @richardshiue
Created: 9/16/2023
Status: Merged
Merged: 9/22/2023
Merged by: @richardshiue

Base: mainHead: checklist-ux


📝 Commits (5)

  • e669185 chore: ux flow redesign
  • bb077c2 chore: remove unused imports
  • 1679312 fix: allow creation of tasks of the same name
  • bf7aaf7 chore: apply code suggestions from Mathias
  • 10388d5 chore: merge remote-tracking branch 'upstream/main' into checklist-ux

📊 Changes

8 files changed (+131 additions, -174 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_cell_test.dart (+1 -11)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+3 -17)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/cells.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart (+34 -11)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor.dart (+87 -120)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+3 -8)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist.rs (+1 -7)

📄 Description

  • solve the new task button vs create confusion. the new task button is no more and the new task text field with the create button is always visible, and separated from the other tasks
  • the create button is now greyed out when the text is empty to indicate to users that you can't submit an empty task
  • editing an existing task now updates it in place without the user having to submit by pressing enter

About the create button's padding Lucas, I figured that since I have it separated, it could be nearer to the edge. If you think it would be better being right aligned with the delete button, LMK!

Screencast_20230916_163937.webm

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3418 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/16/2023 **Status:** ✅ Merged **Merged:** 9/22/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `checklist-ux` --- ### 📝 Commits (5) - [`e669185`](https://github.com/AppFlowy-IO/AppFlowy/commit/e669185dd1bd517cb9fcaf44e3d81eadd4a15429) chore: ux flow redesign - [`bb077c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/bb077c2027dd8974f8ef1715ed26e365ce6431d9) chore: remove unused imports - [`1679312`](https://github.com/AppFlowy-IO/AppFlowy/commit/1679312c7f73563edb58501b4a33964b1d9ac674) fix: allow creation of tasks of the same name - [`bf7aaf7`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf7aaf77cb41dc1fdde02d343a1970afa7e22123) chore: apply code suggestions from Mathias - [`10388d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/10388d53f7fc64ea940d114d34b43f40622d27b6) chore: merge remote-tracking branch 'upstream/main' into checklist-ux ### 📊 Changes **8 files changed** (+131 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_cell_test.dart` (+1 -11) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+3 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/cells.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell.dart` (+34 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/checklist_cell/checklist_cell_editor.dart` (+87 -120) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+3 -8) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist.rs` (+1 -7) </details> ### 📄 Description - solve the new task button vs create confusion. the new task button is no more and the new task text field with the create button is always visible, and separated from the other tasks - the create button is now greyed out when the text is empty to indicate to users that you can't submit an empty task - editing an existing task now updates it in place without the user having to submit by pressing enter About the create button's padding Lucas, I figured that since I have it separated, it could be nearer to the edge. If you think it would be better being right aligned with the delete button, LMK! [Screencast_20230916_163937.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/7b3c2fe7-7bfc-478a-81ac-eaa851a75057) ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:01 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5722
No description provided.