[PR #3495] [MERGED] fix: some issues with the end date #5742

New issue

Closed

opened 2026-03-23 22:20:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3495
Author: @richardshiue
Created: 9/22/2023
Status: ✅ Merged
Merged: 9/24/2023
Merged by: @LucasXu0

Base: main ← Head: end-date-fixes

📝 Commits (4)

1769584 chore: some date editor improvements
58f1b64 chore: only rebuild DatePicker when necessary
d12e97e chore: apply suggestions from code review
75ea217 chore: use Column instead of ListView

📊 Changes

2 files changed (+80 additions, -38 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart (+21 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+59 -35)

📄 Description

color of the unselected days in darkmode. It should blend into the background now
a day selected -> toggle end date -> click on another one . This should immediately set the range
reorganized the editor to not rebuild everything in the top-level bloc builder. Without this, toggling include time will reset the focused day to this month. (sorry Mathias)

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3495 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/22/2023 **Status:** ✅ Merged **Merged:** 9/24/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `end-date-fixes` --- ### 📝 Commits (4) - [`1769584`](https://github.com/AppFlowy-IO/AppFlowy/commit/1769584bb0c5c337e672016a711dd2650cf17ebc) chore: some date editor improvements - [`58f1b64`](https://github.com/AppFlowy-IO/AppFlowy/commit/58f1b64134809f5c5303c893c10b269fbb35a2e1) chore: only rebuild DatePicker when necessary - [`d12e97e`](https://github.com/AppFlowy-IO/AppFlowy/commit/d12e97e883fde44a6fccf04e7bac1dc2ad9e74db) chore: apply suggestions from code review - [`75ea217`](https://github.com/AppFlowy-IO/AppFlowy/commit/75ea2172fe82247533dd978fa487c435ed69922b) chore: use Column instead of ListView ### 📊 Changes **2 files changed** (+80 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart` (+21 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+59 -35) </details> ### 📄 Description - color of the unselected days in darkmode. It should blend into the background now - a day selected -> toggle end date -> click on another one . This should immediately set the range - reorganized the editor to not rebuild everything in the top-level bloc builder. Without this, toggling include time will reset the focused day to this month. (sorry Mathias) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>