[PR #3529] [MERGED] fix: unable to parse html text which contains <mark> tag #5754

New issue

Closed

opened 2026-03-23 22:20:09 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3529
Author: @LucasXu0
Created: 9/25/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @LucasXu0

Base: main ← Head: fix_paste_marked_text_and_image_block_selection

📝 Commits (5)

579e88f fix: option + click doesn't work sometimes
356484b chore: update editor verison to ce8aa6d
3ddea72 chore: add new test into runner
54b5a2c fix: default colors for the blocks except for callout are not transparent
403fe83 Update editor_transaction_adapter.dart

📊 Changes

9 files changed (+105 additions, -13 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/document/document_option_action_test.dart (+44 -0)
📝 frontend/appflowy_flutter/integration_test/document/document_test_runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+31 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart (+8 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart (+4 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+11 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart (+1 -1)

📄 Description

Feature Preview

support parsing the marked html text

source

now

option + click doesn't work sometimes.
image block drag gesture.

before

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ab3c2733-aac6-4dd0-a36c-5de03becd34d

after

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/5a01e844-601d-4200-9b3a-5a7cb41de9a7

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3529 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/25/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_paste_marked_text_and_image_block_selection` --- ### 📝 Commits (5) - [`579e88f`](https://github.com/AppFlowy-IO/AppFlowy/commit/579e88f6c1199afcc9a3f72622bfcd577b00ec82) fix: option + click doesn't work sometimes - [`356484b`](https://github.com/AppFlowy-IO/AppFlowy/commit/356484bcaaa8781ff57ca6e1c76c62159a88779e) chore: update editor verison to ce8aa6d - [`3ddea72`](https://github.com/AppFlowy-IO/AppFlowy/commit/3ddea7275822997269a33b96f66a04b75ad3627c) chore: add new test into runner - [`54b5a2c`](https://github.com/AppFlowy-IO/AppFlowy/commit/54b5a2cfbd83134dec8d0403362db3f018188d52) fix: default colors for the blocks except for callout are not transparent - [`403fe83`](https://github.com/AppFlowy-IO/AppFlowy/commit/403fe8399110e4ac57e5bd008732544da9bd8c6b) Update editor_transaction_adapter.dart ### 📊 Changes **9 files changed** (+105 additions, -13 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/document/document_option_action_test.dart` (+44 -0) 📝 `frontend/appflowy_flutter/integration_test/document/document_test_runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+31 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart` (+8 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option_action.dart` (+4 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+11 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart` (+1 -1) </details> ### 📄 Description   ### Feature Preview - support parsing the marked html text ### source <img width="716" alt="Screenshot 2023-09-25 at 14 44 21" src="https://github.com/AppFlowy-IO/appflowy-editor/assets/11863087/6a3f2325-aded-4a49-9e83-522032f79596"> ### now <img width="722" alt="Screenshot 2023-09-25 at 15 07 54" src="https://github.com/AppFlowy-IO/appflowy-editor/assets/11863087/cba894b0-cbf1-4d8d-b45e-120d1cf6b20e"> - option + click doesn't work sometimes. - image block drag gesture. ### before https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ab3c2733-aac6-4dd0-a36c-5de03becd34d ### after https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/5a01e844-601d-4200-9b3a-5a7cb41de9a7  ---  #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>