[PR #3545] [MERGED] feat: show hidden fields in row detail page #5758

New issue

Closed

opened 2026-03-23 22:20:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3545
Author: @richardshiue
Created: 9/27/2023
Status: ✅ Merged
Merged: 10/2/2023
Merged by: @LucasXu0

Base: main ← Head: edit-hidden-fields

📝 Commits (10+)

2e6a5c6 feat: show hidden fields in row detail page
9e1cc6a fix: don't abuse onFieldChange notifier
4af6e61 fix: default field visibility from protobuf
f718d6d chore: allow showing hidden fields in field editor
cf7c98a chore: use FieldInfo in FIeldContext
b584f06 fix: forgot to field notify
c62db39 fix: hack the field info for create property
d248d0f fix: need to learn how to count
575c3ce test: integration tests 4 integration testing purposes
bcd96a5 chore: merge remote-tracking branch 'upstream/main' into edit-hidden-fields

📊 Changes

23 files changed (+457 additions, -208 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database_row_page_test.dart (+49 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+28 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_action_sheet_bloc.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_cell_bloc.dart (+9 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart (+38 -33)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_service.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field_settings/field_settings_service.dart (+20 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_cache.dart (+5 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_event_editor_bloc.dart (+10 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_bloc.dart (+14 -10)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_detail_bloc.dart (+124 -47)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart (+11 -11)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+35 -23)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/field/grid_property.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+69 -41)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/util.dart (+2 -2)

...and 3 more files

📄 Description

resolves https://github.com/AppFlowy-IO/AppFlowy/issues/2394

❓ Visual indicator for hidden fields in the property list

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3545 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/27/2023 **Status:** ✅ Merged **Merged:** 10/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `edit-hidden-fields` --- ### 📝 Commits (10+) - [`2e6a5c6`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e6a5c6d6d91021f4c697002dac5d7a89b2e15e0) feat: show hidden fields in row detail page - [`9e1cc6a`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e1cc6a828d79a509efdba26c372ed502b81c4f7) fix: don't abuse onFieldChange notifier - [`4af6e61`](https://github.com/AppFlowy-IO/AppFlowy/commit/4af6e610fc60945c76cc3b2bd47c49db6a970f59) fix: default field visibility from protobuf - [`f718d6d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f718d6df2727a35b3317c33a1825552743f0a4a7) chore: allow showing hidden fields in field editor - [`cf7c98a`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf7c98ad392a7588f98bad79e9858cf2d1c5bda7) chore: use FieldInfo in FIeldContext - [`b584f06`](https://github.com/AppFlowy-IO/AppFlowy/commit/b584f062f0d3f21124a51b0a4290d747169dd0cb) fix: forgot to field notify - [`c62db39`](https://github.com/AppFlowy-IO/AppFlowy/commit/c62db39195687a79d0d00cd2fad3882055a16e19) fix: hack the field info for create property - [`d248d0f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d248d0f008b12fe15042f29ee4b0f7ea1f51dc23) fix: need to learn how to count - [`575c3ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/575c3ce7f0067d1d5089cbb355a8be634ea751fe) test: integration tests 4 integration testing purposes - [`bcd96a5`](https://github.com/AppFlowy-IO/AppFlowy/commit/bcd96a5e62ce5bfe8fe490ffa559e481e3f07e5c) chore: merge remote-tracking branch 'upstream/main' into edit-hidden-fields ### 📊 Changes **23 files changed** (+457 additions, -208 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database_row_page_test.dart` (+49 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+28 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_action_sheet_bloc.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_cell_bloc.dart` (+9 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart` (+38 -33) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_service.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field_settings/field_settings_service.dart` (+20 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_cache.dart` (+5 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_event_editor_bloc.dart` (+10 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_bloc.dart` (+14 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_detail_bloc.dart` (+124 -47) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart` (+11 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+35 -23) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/field/grid_property.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+69 -41) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/util.dart` (+2 -2) _...and 3 more files_ </details> ### 📄 Description resolves https://github.com/AppFlowy-IO/AppFlowy/issues/2394 ![Screenshot 2023-09-27 at 3 42 01 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/58845833-cd5f-4c5d-93d9-181be3aad577) ❓ Visual indicator for hidden fields in the property list ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>