[PR #3569] [MERGED] fix: avoid non-null promise on null value on home screen #5771

Closed
opened 2026-03-23 22:20:14 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3569
Author: @Xazin
Created: 10/1/2023
Status: Merged
Merged: 10/2/2023
Merged by: @LucasXu0

Base: mainHead: fix/avoid-promise-not-null-on-nullable


📝 Commits (1)

  • 6fcbadc fix: avoid non-null promise on null value

📊 Changes

3 files changed (+105 additions, -15 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart (+21 -13)
frontend/appflowy_flutter/lib/workspace/presentation/home/errors/workspace_failed_screen.dart (+77 -0)
📝 frontend/resources/translations/en.json (+7 -2)

📄 Description

Resolves: #3568

Feature Preview

Screenshot 2023-10-01 at 23 17 44

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3569 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/1/2023 **Status:** ✅ Merged **Merged:** 10/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/avoid-promise-not-null-on-nullable` --- ### 📝 Commits (1) - [`6fcbadc`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fcbadc08c456b4d20119af98b7c076948a32392) fix: avoid non-null promise on null value ### 📊 Changes **3 files changed** (+105 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart` (+21 -13) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/home/errors/workspace_failed_screen.dart` (+77 -0) 📝 `frontend/resources/translations/en.json` (+7 -2) </details> ### 📄 Description Resolves: #3568 ### Feature Preview <img width="793" alt="Screenshot 2023-10-01 at 23 17 44" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/f93b46e1-9d65-4845-b2ce-7339647aafd5"> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:14 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5771
No description provided.