AppFlowy-IO/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00
Code Issues 952 Projects Packages Wiki Activity

[PR #3637] [MERGED] fix: image block issues #5803

New issue
Closed
opened 2026-03-23 22:20:22 +00:00 by mirror · 0 comments
mirror commented 2026-03-23 22:20:22 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3637
Author: @LucasXu0
Created: 10/6/2023
Status: ✅ Merged
Merged: 10/7/2023
Merged by: @LucasXu0

Base: main ← Head: fix_image_block_issues

📝 Commits (7)

  • 406cdae fix: upload image menu will flicker for one frame after inserting an image
  • accf881 fix: custom image block component cursor overflow
  • 40e0eb7 fix: add padding between unsplash results and search field
  • 5269906 fix: can't use esc to close the image upload menu
  • d909678 fix: add a search button in unsplash image widget
  • 474769b fix: remove theme mode tooltip
  • 737292c test: add integration test for new image block

📊 Changes

10 files changed (+287 additions, -67 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_test_runner.dart (+2 -0)
➕ frontend/appflowy_flutter/integration_test/document/document_with_image_block_test.dart (+147 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/custom_image_block_component.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_placeholder.dart (+14 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/unsplash_image_widget.dart (+39 -16)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart (+18 -33)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+33 -5)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart (+11 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+18 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+3 -1)

📄 Description

Feature Preview

  • remove the tooltip of the theme mode, and add a description under the theme mode text.
  • Add padding between unsplash results and search field
  • cannot use ESC to close the image picker dialog - only when navigating to embed link or unsplash tab
  • No longer able to trigger the menu after selecting image
  • it shouldn’t require Enter to search an image - (Add a search button)
  • Selecting an image from unsplash makes the dialog flicker as it disappear
  • add a loading status when querying from the image service
  • Selecting the image block is strange

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3637 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/6/2023 **Status:** ✅ Merged **Merged:** 10/7/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_image_block_issues` --- ### 📝 Commits (7) - [`406cdae`](https://github.com/AppFlowy-IO/AppFlowy/commit/406cdae6dbf88610ea6837bec8a18cf169d3e7c9) fix: upload image menu will flicker for one frame after inserting an image - [`accf881`](https://github.com/AppFlowy-IO/AppFlowy/commit/accf88179dabc9fe427d9666ce7bdf431be430c0) fix: custom image block component cursor overflow - [`40e0eb7`](https://github.com/AppFlowy-IO/AppFlowy/commit/40e0eb734790629fe216a62a90aaa488cb252451) fix: add padding between unsplash results and search field - [`5269906`](https://github.com/AppFlowy-IO/AppFlowy/commit/5269906346d4e9350c3500768da34cdff59f7b09) fix: can't use esc to close the image upload menu - [`d909678`](https://github.com/AppFlowy-IO/AppFlowy/commit/d9096784cfa57e90dd302da12673a2bf0bb83172) fix: add a search button in unsplash image widget - [`474769b`](https://github.com/AppFlowy-IO/AppFlowy/commit/474769bd440d585b31f2f365cbfe12413c4f0d52) fix: remove theme mode tooltip - [`737292c`](https://github.com/AppFlowy-IO/AppFlowy/commit/737292c31703d74d3d9f526064184df5183ff07d) test: add integration test for new image block ### 📊 Changes **10 files changed** (+287 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_test_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/document/document_with_image_block_test.dart` (+147 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/custom_image_block_component.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_placeholder.dart` (+14 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/unsplash_image_widget.dart` (+39 -16) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/brightness_setting.dart` (+18 -33) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+33 -5) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart` (+11 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+18 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+3 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] remove the tooltip of the theme mode, and add a description under the theme mode text. - [x] Add padding between unsplash results and search field - [x] cannot use ESC to close the image picker dialog - only when navigating to embed link or unsplash tab - [x] No longer able to trigger the menu after selecting image - [x] it shouldn’t require Enter to search an image - (Add a search button) - [x] Selecting an image from unsplash makes the dialog flicker as it disappear - [x] add a loading status when querying from the image service - [x] Selecting the image block is strange <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:22 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
copilot/fix-date-format-issue
feat/mention_a_person
merge_upstream_v6
mobile/release/0.9.3
release/0.9.3
release/0.9.2
select_source
release/0.9.1
refactor_import_data
release/0.8.9.1
release/0.8.9
anon_user_mode
release/0.8.8
fix_windows_selection
release/0.8.7
annieappflowy-patch-1
windows_local_ai
release/0.8.6
release/0.8.5
release/0.8.4
chore/optional-response-format
release/0.8.3
release/0.8.2
release/0.8.1
release/0.8.0
release/0.7.9
feat/support-rename-workspace
chat_rag_only
calculate_ui_test
release/0.7.8
release/0.7.7
stringfi_cells
hotfix/0.7.5
release/0.7.4
client-api-update
feat/collab-editing
fix_calculation_bug
feat/upload-file-in-document
update-client-api
feat/support-global-comment-on-web
update-client-api-2
feat/support-duplicate-publish-on-web
feat/ai-plan-billing
chore/test-web-deploy
chore/enable-billing-for-testing
build/test
ai_tag_feature
chore/enable-billing-plan
feat/billing-client-windows
chore/support-openai-chat
fix/try-no-media-kit
sign-in-error-format
workspace-invite-ci-test
last-workspace
workspace-invite-wip
feat/date-text-input
appflowy_v1
0.11.1
0.11.0
0.10.9
0.11.2
0.10.7
0.10.6
0.10.5
0.11.3
0.11.4
0.10.8
0.10.4
0.10.3
0.10.2
0.10.0
0.10.1
0.9.9
0.9.8
0.9.7
0.9.5
0.9.6
0.9.4
0.9.3
0.9.2
0.9.1
0.9.0
0.8.9
0.8.8
0.8.7
0.8.6
0.8.5
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.9
0.7.8
0.7.7
0.7.6
0.7.5
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.9
0.6.8
0.6.7.2
0.6.7.1
0.6.7
0.6.6
0.6.5
0.6.4
0.6.3
0.6.2
0.6.1
v0.6.1
0.6.0
0.5.9
0.5.8
0.5.7
0.5.6
0.5.5
0.5.4
0.5.3
0.5.2
0.5.1
0.5.0
0.4.9
0.4.8
0.4.7
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.9.1
0.3.9
0.3.8
0.3.7
0.3.6
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.2.9
0.2.8
0.2.7
0.2.6
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.9.1
0.0.9
0.0.8.1
0.0.8
0.0.7.1
0.0.7
0.0.6.2
0.0.6.1
0.0.6
0.0.6_beta.1
0.0.5.3
0.0.5.2
0.0.5.1
0.0.5
0.0.5_beta.2
0.0.5_beta.1
0.0.4
0.0.4_beta.3
0.0.4_beta.2
0.0.4_beta.1
0.0.3
0.0.3_beta.2
0.0.3_beta.1
0.0.2
0.0.1
Labels
Clear labels   
2024

   
2025

   
2026

   
acct mgmt

   
AI

   
automation

   
bug

   
calendar

   
ci

   
CJK

   
cloud

   
code-block

   
collaboration

   
copy-paste

   
database

   
data migration

   
data sync

   
deploy

   
desktop

   
develop

   
develop

   
documentation

   
duplicate

   
editor

   
editor-plugin

   
emoji

   
export

   
files

   
flutter-only

   
follow-up

   
formula

   
good first issue for devs

   
good first issue for experienced devs

   
grid

   
hacktoberfest

   
HACKTOBERFEST-ACCEPTED

   
help wanted

   
i18n

   
icons

   
images

   
importer

   
improvements

   
infra

   
install

   
integrations

   
IR

   
kanban board

   
login

   
look and joy

   
mentorship

   
mobile

   
mobile

   
needs design

   
new feature

   
new feature

   
non-coding

   
notes

   
notifications

   
onboarding

   
organization

   
P0+

   
permission

   
platform-linux

   
platform-mac

   
platform-windows

   
plugins

   
program

   
pull-request

Mirrored from GitHub Pull Request

  
Q1 25

   
Q1 26

   
Q2 24

   
Q2 25

   
Q3 24

   
Q3 25

   
Q4 24

   
Q4 25

   
react

   
regression

   
rust

   
rust

   
Rust-only

   
Rust-only

   
Rust-starter

   
Rust-starter

   
self-hosted

   
shortcuts

   
side panel

   
slash-menu

   
sync v2

   
table

   
tablet

   
task

   
tauri

   
templates

   
tests

   
themes

   
translation

   
v0.5.6

   
v0.5.8

   
v0.5.9

   
v0.6.0

   
v0.6.1

   
v0.6.4

   
v0.6.7

   
v0.6.8

   
v0.7.1

   
v0.7.4

   
v0.7.4

   
v0.7.5

   
v0.7.6

   
v0.7.7

   
v0.7.8

   
v0.8.0

   
v0.8.4

   
v0.8.5

   
v0.8.9

   
web
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5803
No description provided.