[PR #3706] [MERGED] fix: The appearance of slash menu didn't change along with theme mode changes (#3630) #5838

New issue

Closed

opened 2026-03-23 22:20:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3706
Author: @lielfr
Created: 10/15/2023
Status: ✅ Merged
Merged: 10/24/2023
Merged by: @LucasXu0

Base: main ← Head: fix-3630

📝 Commits (4)

68f810f fix: The appearance of slash menu didn't change along with theme mode changes (#3630)
e46c660 Merge branch 'main' into fix-3630
5e5cbfd revert: pubspec.lock change
f43e9c1 fix: use context inside of function

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+9 -6)

📄 Description

What (I think) happened was that the theme was not being updated based on the context, so I moved the showSlashMenu function to accept the current context and call the builder from within. Not sure if it is the best way to do it, but seems to work:

https://github.com/AppFlowy-IO/AppFlowy/assets/360928/4a5f1bdb-95c3-482d-bd41-c3183648d290

Feature Preview

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3630

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3706 **Author:** [@lielfr](https://github.com/lielfr) **Created:** 10/15/2023 **Status:** ✅ Merged **Merged:** 10/24/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-3630` --- ### 📝 Commits (4) - [`68f810f`](https://github.com/AppFlowy-IO/AppFlowy/commit/68f810f3d0931e5d35f034e00c22969ab6fdc467) fix: The appearance of slash menu didn't change along with theme mode changes (#3630) - [`e46c660`](https://github.com/AppFlowy-IO/AppFlowy/commit/e46c660512485f34d8950c2041240e081e157fd9) Merge branch 'main' into fix-3630 - [`5e5cbfd`](https://github.com/AppFlowy-IO/AppFlowy/commit/5e5cbfdd560944c570823ff2f83dd51de4cc1b8d) revert: pubspec.lock change - [`f43e9c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/f43e9c1ecc00322fa8836fe8253d3f0c31d8a43a) fix: use context inside of function ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+9 -6) </details> ### 📄 Description  What (I think) happened was that the theme was not being updated based on the context, so I moved the `showSlashMenu` function to accept the current context and call the builder from within. Not sure if it is the best way to do it, but seems to work: https://github.com/AppFlowy-IO/AppFlowy/assets/360928/4a5f1bdb-95c3-482d-bd41-c3183648d290 ### Feature Preview  fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3630 ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>