[PR #3716] [MERGED] fix: reminder launch review #5843

New issue

Closed

opened 2026-03-23 22:20:33 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3716
Author: @Xazin
Created: 10/16/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @LucasXu0

Base: main ← Head: fix/launch-review-reminder

📝 Commits (6)

4cb6911 fix: include time in notification hub
2db1d0f fix: tooltip for time textfield
a60a9b3 feat: implement new notification hub design
eeb48ab fix: spacing in settings
37dcc37 fix: fontsize of segmented button
6e75003 fix: change unselected bg

📊 Changes

29 files changed (+519 additions, -566 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+8 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+12 -4)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/reminder_reference.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/user/application/notification_filter/notification_filter_bloc.dart (+2 -29)
📝 frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart (+33 -4)
➕ frontend/appflowy_flutter/lib/user/application/reminder/reminder_extension.dart (+17 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/notifications/notification_action.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/notifications/notification_action_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/notifications/notification_service.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_user.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_dialog.dart (+154 -287)
➖ frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_group.dart (+0 -58)
➖ frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_grouped_view.dart (+0 -65)
➖ frontend/appflowy_flutter/lib/workspace/presentation/notifications/notifications_hub_empty.dart (+0 -20)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart (+3 -1)
➕ frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_hub_title.dart (+23 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart (+56 -54)

...and 9 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3716 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/16/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/launch-review-reminder` --- ### 📝 Commits (6) - [`4cb6911`](https://github.com/AppFlowy-IO/AppFlowy/commit/4cb691162db04dba3d691be6f92e11afbd8c315c) fix: include time in notification hub - [`2db1d0f`](https://github.com/AppFlowy-IO/AppFlowy/commit/2db1d0ff40f1a2bf42177db25f6c588473271f50) fix: tooltip for time textfield - [`a60a9b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/a60a9b3001178d3d66622918e2d436c6f1c873e5) feat: implement new notification hub design - [`eeb48ab`](https://github.com/AppFlowy-IO/AppFlowy/commit/eeb48ab3a2166dc3f366e224b09c0273aeb2adc4) fix: spacing in settings - [`37dcc37`](https://github.com/AppFlowy-IO/AppFlowy/commit/37dcc372176927e39e5499e498907888cfbc2d76) fix: fontsize of segmented button - [`6e75003`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e750038b9d2c5123cfa14ccff203a89998d2fa9) fix: change unselected bg ### 📊 Changes **29 files changed** (+519 additions, -566 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+8 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+12 -4) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/reminder_reference.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/user/application/notification_filter/notification_filter_bloc.dart` (+2 -29) 📝 `frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart` (+33 -4) ➕ `frontend/appflowy_flutter/lib/user/application/reminder/reminder_extension.dart` (+17 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/notifications/notification_action.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/notifications/notification_action_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/notifications/notification_service.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_user.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_dialog.dart` (+154 -287) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_group.dart` (+0 -58) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_grouped_view.dart` (+0 -65) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/notifications/notifications_hub_empty.dart` (+0 -20) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart` (+3 -1) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_hub_title.dart` (+23 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart` (+56 -54) _...and 9 more files_ </details> ### 📄 Description ### Feature Preview <img width="462" alt="Screenshot 2023-10-16 at 20 41 06" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/7a04b60c-2b15-4309-b6de-b7be1154adc6"> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>