[PR #3756] [MERGED] chore: improve setting tab bar dropdown #5864

Closed
opened 2026-03-23 22:20:39 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3756
Author: @richardshiue
Created: 10/23/2023
Status: Merged
Merged: 10/23/2023
Merged by: @richardshiue

Base: mainHead: setting-toolbar-popover-revamp


📝 Commits (2)

  • 0112d1f chore: improve setting tab bar dropdown
  • 1c351de test: fix integration tests

📊 Changes

6 files changed (+178 additions, -172 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+5 -6)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/setting/property_bloc.dart (+21 -11)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart (+2 -0)
frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_setting.dart (+0 -75)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_button.dart (+86 -56)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart (+64 -24)

📄 Description

fix https://github.com/AppFlowy-IO/AppFlowy/issues/3382
fix https://github.com/AppFlowy-IO/AppFlowy/issues/3740
fix https://github.com/AppFlowy-IO/AppFlowy/issues/3456

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/76f9c7d8-e59a-4831-a7de-7e52349ac766

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3756 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/23/2023 **Status:** ✅ Merged **Merged:** 10/23/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `setting-toolbar-popover-revamp` --- ### 📝 Commits (2) - [`0112d1f`](https://github.com/AppFlowy-IO/AppFlowy/commit/0112d1fab6f6a1bb8a57f7d82894b65f34c82e6b) chore: improve setting tab bar dropdown - [`1c351de`](https://github.com/AppFlowy-IO/AppFlowy/commit/1c351dee9bf6a89ceb2d974ce33a687428e209ff) test: fix integration tests ### 📊 Changes **6 files changed** (+178 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+5 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/setting/property_bloc.dart` (+21 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart` (+2 -0) ➖ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_setting.dart` (+0 -75) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_button.dart` (+86 -56) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart` (+64 -24) </details> ### 📄 Description fix https://github.com/AppFlowy-IO/AppFlowy/issues/3382 fix https://github.com/AppFlowy-IO/AppFlowy/issues/3740 fix https://github.com/AppFlowy-IO/AppFlowy/issues/3456 https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/76f9c7d8-e59a-4831-a7de-7e52349ac766 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:39 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5864
No description provided.