[PR #3766] [MERGED] fix: font size text being displayed out of range. #5867

Closed
opened 2026-03-23 22:20:40 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3766
Author: @ZakAnun
Created: 10/23/2023
Status: Merged
Merged: 10/24/2023
Merged by: @LucasXu0

Base: mainHead: fix_issue_3749


📝 Commits (2)

  • b6dcff8 fix: font size text being displayed out of range.
  • 6ca762a chore: refactor code

📊 Changes

2 files changed (+59 additions, -40 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/font_size_switcher.dart (+42 -26)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart (+17 -14)

📄 Description

Feature Preview

Fix issue 3749. By following changes:

  1. Increase PopupMenuButton maximum width to adapt to sub widget width display.
  2. Use SegmentedButton to replace ToggleButton for better display.
image image image

fix #3749


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3766 **Author:** [@ZakAnun](https://github.com/ZakAnun) **Created:** 10/23/2023 **Status:** ✅ Merged **Merged:** 10/24/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_issue_3749` --- ### 📝 Commits (2) - [`b6dcff8`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6dcff8b9481fe9a972fcbaf0b8828d6ba7367ae) fix: font size text being displayed out of range. - [`6ca762a`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ca762aadf51726ee6da74d785ae50c713d83d10) chore: refactor code ### 📊 Changes **2 files changed** (+59 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/font_size_switcher.dart` (+42 -26) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart` (+17 -14) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview Fix [issue 3749](https://github.com/AppFlowy-IO/AppFlowy/issues/3749). By following changes: 1. Increase PopupMenuButton maximum width to adapt to sub widget width display. 2. Use SegmentedButton to replace ToggleButton for better display. <img width="1670" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/12393222/b98e17a8-047b-4057-9905-3f0475909d51"> <img width="1668" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/12393222/20fbd547-ef65-452c-a83e-3c1cc8f3e35b"> <img width="1666" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/12393222/9f2c9a98-c94c-4e1e-b485-5c34e5db596f"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> fix [#3749 ](https://github.com/AppFlowy-IO/AppFlowy/issues/3749) --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:40 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5867
No description provided.